diff options
| author | Feng, Bob C <bob.c.feng@intel.com> | 2019-08-28 15:33:45 +0800 |
|---|---|---|
| committer | Feng, Bob C <bob.c.feng@intel.com> | 2019-08-29 11:07:48 +0800 |
| commit | df43ea6c08100487776bb0962c657d214e345ae7 (patch) | |
| tree | 1fe7a2cea4bddabdf1412abcf1eb4025aa87f468 | |
| parent | 30b4abc6e9141356639207d1cc280058a0229a36 (diff) | |
| download | edk2-df43ea6c08100487776bb0962c657d214e345ae7.tar.gz edk2-df43ea6c08100487776bb0962c657d214e345ae7.tar.bz2 edk2-df43ea6c08100487776bb0962c657d214e345ae7.zip | |
BaseTools: fix an incremental build issue.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2137
This patch is going to fix a regression issue of incremental
build which was introduced by the commit 94459080c.
The changing on INF file will not trigger module rebuild.
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Steven Shi <steven.shi@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
| -rwxr-xr-x | BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py index 2cd0d3859e..f610365f6d 100755 --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py @@ -1766,12 +1766,8 @@ class ModuleAutoGen(AutoGen): if os.path.exists (self.TimeStampPath):
os.remove (self.TimeStampPath)
- with tempfile.NamedTemporaryFile('w+', dir=os.path.dirname(self.TimeStampPath), delete=False) as tf:
- for f in FileSet:
- tf.write(f)
- tf.write("\n")
- tempname = tf.name
- SaveFileOnChange(self.TimeStampPath, tempname, False)
+
+ SaveFileOnChange(self.TimeStampPath, "\n".join(FileSet), False)
# Ignore generating makefile when it is a binary module
if self.IsBinaryModule:
|