diff options
| author | Jiaxin Wu <jiaxin.wu@intel.com> | 2018-01-02 11:29:03 +0800 |
|---|---|---|
| committer | Jiaxin Wu <jiaxin.wu@intel.com> | 2018-01-10 08:32:47 +0800 |
| commit | 1e4725e569960b1107c11df6c404312d26129eab (patch) | |
| tree | b5add4a19ecb3110291ed6008e2238ee01681e8c | |
| parent | 36c19ee6c7c4455f5de2817052444d1a0dad0e3d (diff) | |
| download | edk2-1e4725e569960b1107c11df6c404312d26129eab.tar.gz edk2-1e4725e569960b1107c11df6c404312d26129eab.tar.bz2 edk2-1e4725e569960b1107c11df6c404312d26129eab.zip | |
NetworkPkg/HttpDxe: Fix build warning error if CHAR8 is unsigned.
This patch is to fix the compiler warning error: C4245. The issue will happen
if the below build option is enabled:
*_*_*_CC_FLAGS = -J.
That's because the value of ('A' - 'a') is a negative value, which will
be converted to an unsigned type if CHAR8 is treated as unsigned:
Src -= ('A' - 'a');
The above issue is also recorded at:
https://bugzilla.tianocore.org/show_bug.cgi?id=815.
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
| -rw-r--r-- | NetworkPkg/HttpDxe/HttpsSupport.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c b/NetworkPkg/HttpDxe/HttpsSupport.c index e6f4d5a6cc..6aed61a3a4 100644 --- a/NetworkPkg/HttpDxe/HttpsSupport.c +++ b/NetworkPkg/HttpDxe/HttpsSupport.c @@ -67,11 +67,11 @@ AsciiStrCaseStr ( Dst = *SearchStringTmp;
if ((Src >= 'A') && (Src <= 'Z')) {
- Src -= ('A' - 'a');
+ Src += ('a' - 'A');
}
if ((Dst >= 'A') && (Dst <= 'Z')) {
- Dst -= ('A' - 'a');
+ Dst += ('a' - 'A');
}
if (Src != Dst) {
|