diff options
| author | GregX Yeh <gregx.yeh@intel.com> | 2021-01-15 14:22:56 +0800 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2021-01-20 12:33:38 +0000 |
| commit | ca272b9513a6de5772e6e8ef5bbecd2e23cf9fb3 (patch) | |
| tree | 24c4806f3e7ec354fabd53685d476fbb82f0c9d6 | |
| parent | 6e5586863148773c15399ead249711143a74d2d0 (diff) | |
| download | edk2-ca272b9513a6de5772e6e8ef5bbecd2e23cf9fb3.tar.gz edk2-ca272b9513a6de5772e6e8ef5bbecd2e23cf9fb3.tar.bz2 edk2-ca272b9513a6de5772e6e8ef5bbecd2e23cf9fb3.zip | |
DxeHttpIoLib: Http boot failure with no initializes timeout value.
https://bugzilla.tianocore.org/show_bug.cgi?id=3170
Using PcdHttpIoTimeout to set default timeout value to HttpIoLib.
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: GregX Yeh <gregx.yeh@intel.com>
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
| -rw-r--r-- | NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c | 1 | ||||
| -rw-r--r-- | NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf | 1 | ||||
| -rw-r--r-- | NetworkPkg/NetworkPkg.dec | 6 |
3 files changed, 7 insertions, 1 deletions
diff --git a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c b/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c index 67583fb220..04b01adec5 100644 --- a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c +++ b/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.c @@ -189,6 +189,7 @@ HttpIoCreateIo ( HttpIo->Http = Http;
HttpIo->Callback = Callback;
HttpIo->Context = Context;
+ HttpIo->Timeout = PcdGet32 (PcdHttpIoTimeout);
if (ConfigData != NULL) {
if (HttpIo->IpVersion == IP_VERSION_4) {
diff --git a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf b/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf index 25f5eb2ec6..347f8d5508 100644 --- a/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf +++ b/NetworkPkg/Library/DxeHttpIoLib/DxeHttpIoLib.inf @@ -43,3 +43,4 @@ [Pcd]
gEfiNetworkPkgTokenSpaceGuid.PcdMaxHttpChunkTransfer ## SOMETIMES_CONSUMES
+ gEfiNetworkPkgTokenSpaceGuid.PcdHttpIoTimeout ## SOMETIMES_CONSUMES
diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec index 2d0d7fd2dc..b81f10ef6e 100644 --- a/NetworkPkg/NetworkPkg.dec +++ b/NetworkPkg/NetworkPkg.dec @@ -3,7 +3,7 @@ #
# This package provides network modules that conform to UEFI 2.4 specification.
#
-# Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2009 - 2021, Intel Corporation. All rights reserved.<BR>
# (C) Copyright 2015-2020 Hewlett Packard Enterprise Development LP<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -97,6 +97,10 @@ # @Prompt Max size of total HTTP chunk transfer. the default value is 12MB.
gEfiNetworkPkgTokenSpaceGuid.PcdMaxHttpChunkTransfer|0x0C00000|UINT32|0x0000000E
+ ## The Timeout value of HTTP IO.
+ # @Prompt The Timeout value of HTTP Io. Default value is 5000.
+ gEfiNetworkPkgTokenSpaceGuid.PcdHttpIoTimeout|5000|UINT32|0x0000000F
+
[PcdsFixedAtBuild, PcdsPatchableInModule]
## Indicates whether HTTP connections (i.e., unsecured) are permitted or not.
# TRUE - HTTP connections are allowed. Both the "https://" and "http://" URI schemes are permitted.
|