diff options
| author | Pierre Gondois <Pierre.Gondois@arm.com> | 2021-01-15 17:31:32 +0000 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2021-04-15 19:53:39 +0000 |
| commit | 063f8483b94a23ad4969ff8cafeb49b2068ae3a5 (patch) | |
| tree | 8380b6f077edf34aef5b980cc85ca565d0b40ce8 /ArmPkg | |
| parent | bd8efb4f8e805337599e2fe7eb2b84bb5b38e282 (diff) | |
| download | edk2-063f8483b94a23ad4969ff8cafeb49b2068ae3a5.tar.gz edk2-063f8483b94a23ad4969ff8cafeb49b2068ae3a5.tar.bz2 edk2-063f8483b94a23ad4969ff8cafeb49b2068ae3a5.zip | |
ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Diffstat (limited to 'ArmPkg')
| -rw-r--r-- | ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 8 | ||||
| -rw-r--r-- | ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h | 6 | ||||
| -rw-r--r-- | ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 8 |
3 files changed, 11 insertions, 11 deletions
diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c index 9cd3a7ed23..cc223d6720 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c @@ -152,10 +152,10 @@ ClockGetClockAttributes ( @param[in] This A pointer to SCMI_CLOCK_PROTOCOL Instance.
@param[in] ClockId Identifier for the clock device.
- @param[out] Format SCMI_CLOCK_RATE_FORMAT_DISCRETE: Clock device
+ @param[out] Format ScmiClockRateFormatDiscrete: Clock device
supports range of clock rates which are non-linear.
- SCMI_CLOCK_RATE_FORMAT_LINEAR: Clock device supports
+ ScmiClockRateFormatLinear: Clock device supports
range of linear clock rates from Min to Max in steps.
@param[out] TotalRates Total number of rates.
@@ -236,7 +236,7 @@ ClockDescribeRates ( *TotalRates = NUM_RATES (DescribeRates->NumRatesFlags)
+ NUM_REMAIN_RATES (DescribeRates->NumRatesFlags);
- if (*Format == SCMI_CLOCK_RATE_FORMAT_DISCRETE) {
+ if (*Format == ScmiClockRateFormatDiscrete) {
RequiredArraySize = (*TotalRates) * sizeof (UINT64);
} else {
// We need to return triplet of 64 bit value for each rate
@@ -251,7 +251,7 @@ ClockDescribeRates ( RateOffset = 0;
- if (*Format == SCMI_CLOCK_RATE_FORMAT_DISCRETE) {
+ if (*Format == ScmiClockRateFormatDiscrete) {
for (RateNo = 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags); RateNo++) {
Rate = &DescribeRates->Rates[RateOffset++];
// Non-linear discrete rates.
diff --git a/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h b/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h index 950141cbd2..0e26491a62 100644 --- a/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h @@ -1,6 +1,6 @@ /** @file
- Copyright (c) 2017-2018, Arm Limited. All rights reserved.
+ Copyright (c) 2017-2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -89,10 +89,10 @@ EFI_STATUS @param[in] This A pointer to SCMI_CLOCK2_PROTOCOL Instance.
@param[in] ClockId Identifier for the clock device.
- @param[out] Format SCMI_CLOCK_RATE_FORMAT_DISCRETE: Clock device
+ @param[out] Format ScmiClockRateFormatDiscrete: Clock device
supports range of clock rates which are non-linear.
- SCMI_CLOCK_RATE_FORMAT_LINEAR: Clock device supports
+ ScmiClockRateFormatLinear: Clock device supports
range of linear clock rates from Min to Max in steps.
@param[out] TotalRates Total number of rates.
diff --git a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h index cd62f05a58..4210a53cf9 100644 --- a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h @@ -30,8 +30,8 @@ typedef enum { } SCMI_MESSAGE_ID_CLOCK;
typedef enum {
- SCMI_CLOCK_RATE_FORMAT_DISCRETE, // Non-linear range.
- SCMI_CLOCK_RATE_FORMAT_LINEAR // Linear range.
+ ScmiClockRateFormatDiscrete, // Non-linear range.
+ ScmiClockRateFormatLinear // Linear range.
} SCMI_CLOCK_RATE_FORMAT;
// Clock management protocol version.
@@ -139,10 +139,10 @@ EFI_STATUS @param[in] This A pointer to SCMI_CLOCK_PROTOCOL Instance.
@param[in] ClockId Identifier for the clock device.
- @param[out] Format SCMI_CLOCK_RATE_FORMAT_DISCRETE: Clock device
+ @param[out] Format ScmiClockRateFormatDiscrete: Clock device
supports range of clock rates which are non-linear.
- SCMI_CLOCK_RATE_FORMAT_LINEAR: Clock device supports
+ ScmiClockRateFormatLinear: Clock device supports
range of linear clock rates from Min to Max in steps.
@param[out] TotalRates Total number of rates.
|