summaryrefslogtreecommitdiffstats
path: root/ArmPlatformPkg/Library
diff options
context:
space:
mode:
authorGirish Pathak <girish.pathak@arm.com>2018-02-14 11:52:46 +0000
committerLeif Lindholm <leif.lindholm@linaro.org>2018-04-23 12:00:46 +0100
commitb5daabdcd8a88db615a5d1dfb7b35b61b1ede0c5 (patch)
treea1c9173036f69a46299f829897e933c66c0b15e4 /ArmPlatformPkg/Library
parentd1ee57e581d75852b5ba0bbdaf28a83c6b9230fd (diff)
downloadedk2-b5daabdcd8a88db615a5d1dfb7b35b61b1ede0c5.tar.gz
edk2-b5daabdcd8a88db615a5d1dfb7b35b61b1ede0c5.tar.bz2
edk2-b5daabdcd8a88db615a5d1dfb7b35b61b1ede0c5.zip
ArmPlatformPkg: PL111Lcd: Combine two writes to LCDControl
Currenty bit LcdPwr of the LCDControl register is enabled immediately after setting other bits of the LCDControl register. This two write sequence is unnecessary. This change removes this extra write by setting LcdPwr bit along with other bits of the LcdControl register. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pathak@arm.com> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Diffstat (limited to 'ArmPlatformPkg/Library')
-rw-r--r--ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c
index 287e3ca272..465cb68454 100644
--- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c
+++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c
@@ -137,11 +137,7 @@ LcdSetMode (
// PL111_REG_LCD_CONTROL
LcdControl = PL111_CTRL_LCD_EN | PL111_CTRL_LCD_BPP (LcdBpp) |
- PL111_CTRL_LCD_TFT | PL111_CTRL_BGR;
- MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl);
-
- // Turn on power to the LCD Panel
- LcdControl |= PL111_CTRL_LCD_PWR;
+ PL111_CTRL_LCD_TFT | PL111_CTRL_LCD_PWR | PL111_CTRL_BGR;
MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl);
return EFI_SUCCESS;