diff options
author | Carsey, Jaben <jaben.carsey@intel.com> | 2018-08-29 22:42:21 +0800 |
---|---|---|
committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-08-30 21:05:18 +0800 |
commit | f5f4667dae711a7e34c75a4cd8f7a683c732a566 (patch) | |
tree | 2481cbd594a90b833dee24bdae8410aa3d2aef75 /BaseTools/Source/Python/AutoGen/AutoGen.py | |
parent | 0fece18d6df83cede91a4c8644c2278e63794a62 (diff) | |
download | edk2-f5f4667dae711a7e34c75a4cd8f7a683c732a566.tar.gz edk2-f5f4667dae711a7e34c75a4cd8f7a683c732a566.tar.bz2 edk2-f5f4667dae711a7e34c75a4cd8f7a683c732a566.zip |
BaseTools: Refactor to remove functionally equivalent functions
IsSupportedArch and IsBinaryModule return the same value under the same
curcimstances. Remove newer one with fewer callers and send them to the
other function.
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/AutoGen/AutoGen.py')
-rw-r--r-- | BaseTools/Source/Python/AutoGen/AutoGen.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index 15365e7b1d..95370d1821 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -1091,7 +1091,7 @@ class PlatformAutoGen(AutoGen): for Inf in self._AsBuildInfList:
InfClass = PathClass(NormPath(Inf), GlobalData.gWorkspace, self.Arch)
M = self.BuildDatabase[InfClass, self.Arch, self.BuildTarget, self.ToolChain]
- if not M.IsSupportedArch:
+ if not M.IsBinaryModule:
continue
self._AsBuildModuleList.append(InfClass)
# get library/modules for build
@@ -1346,7 +1346,7 @@ class PlatformAutoGen(AutoGen): # If a module INF in FDF but not in current arch's DSC module list, it must be module (either binary or source)
# for different Arch. PCDs in source module for different Arch is already added before, so skip the source module here.
# For binary module, if in current arch, we need to list the PCDs into database.
- if not M.IsSupportedArch:
+ if not M.IsBinaryModule:
continue
# Override the module PCD setting by platform setting
ModulePcdList = self.ApplyPcdSetting(M, M.Pcds)
|