diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2018-05-13 00:13:53 +0200 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2018-05-14 15:23:54 +0200 |
| commit | f803c03cc2e0b6b0b0bed447a97ea2c61b04ed82 (patch) | |
| tree | ae837b9fa464844e390fd7c5b5eb87d0da73f5df /BaseTools/Source/Python/AutoGen/AutoGen.py | |
| parent | 989f7a2cf0e27123fda5ca538b15832e115e0f4e (diff) | |
| download | edk2-f803c03cc2e0b6b0b0bed447a97ea2c61b04ed82.tar.gz edk2-f803c03cc2e0b6b0b0bed447a97ea2c61b04ed82.tar.bz2 edk2-f803c03cc2e0b6b0b0bed447a97ea2c61b04ed82.zip | |
OvmfPkg/PlatformBootManagerLib: connect consoles unconditionally
If both ConIn and ConOut exist, but ConIn references none of the PS/2
keyboard, the USB wild-card keyboard, and any serial ports, then
PlatformInitializeConsole() currently allows the boot to proceed without
any input devices at all. This makes for a bad user experience -- the
firmware menu could only be entered through OsIndications, set by a guest
OS.
Do what ArmVirtQemu does already, namely connect the consoles, and add
them to ConIn / ConOut / ErrOut, unconditionally. (The underlying
EfiBootManagerUpdateConsoleVariable() function checks for duplicates.)
The issue used to be masked by the EfiBootManagerConnectAll() call that
got conditionalized in commit 245c643cc8b7.
This patch is best viewed with "git show -b -W".
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Fixes: 245c643cc8b73240c3b88cb55b2911b285a8c10d
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1577546
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Diffstat (limited to 'BaseTools/Source/Python/AutoGen/AutoGen.py')
0 files changed, 0 insertions, 0 deletions