diff options
| author | Carsey, Jaben <jaben.carsey@intel.com> | 2018-04-28 06:32:20 +0800 |
|---|---|---|
| committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-05-04 13:02:59 +0800 |
| commit | bffcfca88f398ea42a6275f87561ed57db3c7619 (patch) | |
| tree | a10f2cad9f01f5ec6d7655e059631b1057fdca50 /BaseTools/Source/Python/AutoGen/GenVar.py | |
| parent | dea5ef9dc41c5d7a1a6b20a9457433faf92cc623 (diff) | |
| download | edk2-bffcfca88f398ea42a6275f87561ed57db3c7619.tar.gz edk2-bffcfca88f398ea42a6275f87561ed57db3c7619.tar.bz2 edk2-bffcfca88f398ea42a6275f87561ed57db3c7619.zip | |
BaseTools: AutoGen - refactor dictionary access
dont use dict.get() inside loops of dictionary contents. its not needed.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/AutoGen/GenVar.py')
| -rw-r--r-- | BaseTools/Source/Python/AutoGen/GenVar.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/BaseTools/Source/Python/AutoGen/GenVar.py b/BaseTools/Source/Python/AutoGen/GenVar.py index b8f40da9a3..b9517d84c6 100644 --- a/BaseTools/Source/Python/AutoGen/GenVar.py +++ b/BaseTools/Source/Python/AutoGen/GenVar.py @@ -144,7 +144,7 @@ class VariableMgr(object): default_data_buffer = ""
others_data_buffer = ""
tail = None
- default_sku_default = indexedvarinfo.get(index).get((DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT))
+ default_sku_default = indexedvarinfo[index].get((DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT))
if default_sku_default.data_type not in DataType.TAB_PCD_NUMERIC_TYPES:
var_max_len = max([len(var_item.default_value.split(",")) for var_item in sku_var_info.values()])
@@ -159,11 +159,11 @@ class VariableMgr(object): var_data[(DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT)][index] = (default_data_buffer,sku_var_info[(DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT)])
- for (skuid,defaultstoragename) in indexedvarinfo.get(index):
+ for (skuid,defaultstoragename) in indexedvarinfo[index]:
tail = None
if (skuid,defaultstoragename) == (DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT):
continue
- other_sku_other = indexedvarinfo.get(index).get((skuid,defaultstoragename))
+ other_sku_other = indexedvarinfo[index][(skuid,defaultstoragename)]
if default_sku_default.data_type not in DataType.TAB_PCD_NUMERIC_TYPES:
if len(other_sku_other.default_value.split(",")) < var_max_len:
@@ -220,7 +220,7 @@ class VariableMgr(object): for skuname,defaultstore in var_data:
if (skuname,defaultstore) == (DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT):
continue
- pcds_sku_data = var_data.get((skuname,defaultstore))
+ pcds_sku_data = var_data[(skuname,defaultstore)]
delta_data_set = []
for pcdindex in pcds_sku_data:
offset = var_data_offset[pcdindex]
|