diff options
| author | Carsey, Jaben <jaben.carsey@intel.com> | 2018-04-28 06:32:54 +0800 |
|---|---|---|
| committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-05-04 13:08:09 +0800 |
| commit | 8252e6bf2ddfa210992c3590008029933592ad16 (patch) | |
| tree | 34cc618710565f98d401c2f60b3fa7a6ff9ae2d1 /BaseTools/Source/Python/Common/String.py | |
| parent | 4d601fc6b17d69cf20c23cfbaf063bb337b4876d (diff) | |
| download | edk2-8252e6bf2ddfa210992c3590008029933592ad16.tar.gz edk2-8252e6bf2ddfa210992c3590008029933592ad16.tar.bz2 edk2-8252e6bf2ddfa210992c3590008029933592ad16.zip | |
BaseTools: dont make iterator into list if not needed
functions (like join) can use the iterator just as easily.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/Common/String.py')
| -rw-r--r-- | BaseTools/Source/Python/Common/String.py | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/BaseTools/Source/Python/Common/String.py b/BaseTools/Source/Python/Common/String.py index ee26d7f7b1..34361ecdd5 100644 --- a/BaseTools/Source/Python/Common/String.py +++ b/BaseTools/Source/Python/Common/String.py @@ -818,27 +818,27 @@ def StringToArray(String): if isinstance(String, unicode):
if len(unicode) == 0:
return "{0x00,0x00}"
- return "{%s,0x00,0x00}" % ",".join(["0x%02x,0x00" % ord(C) for C in String])
+ return "{%s,0x00,0x00}" % ",".join("0x%02x,0x00" % ord(C) for C in String)
elif String.startswith('L"'):
if String == "L\"\"":
return "{0x00,0x00}"
else:
- return "{%s,0x00,0x00}" % ",".join(["0x%02x,0x00" % ord(C) for C in String[2:-1]])
+ return "{%s,0x00,0x00}" % ",".join("0x%02x,0x00" % ord(C) for C in String[2:-1])
elif String.startswith('"'):
if String == "\"\"":
return "{0x00,0x00}"
else:
StringLen = len(String[1:-1])
if StringLen % 2:
- return "{%s,0x00}" % ",".join(["0x%02x" % ord(C) for C in String[1:-1]])
+ return "{%s,0x00}" % ",".join("0x%02x" % ord(C) for C in String[1:-1])
else:
- return "{%s,0x00,0x00}" % ",".join(["0x%02x" % ord(C) for C in String[1:-1]])
+ return "{%s,0x00,0x00}" % ",".join("0x%02x" % ord(C) for C in String[1:-1])
elif String.startswith('{'):
StringLen = len(String.split(","))
if StringLen % 2:
- return "{%s,0x00}" % ",".join([ C.strip() for C in String[1:-1].split(',')])
+ return "{%s,0x00}" % ",".join(C.strip() for C in String[1:-1].split(','))
else:
- return "{%s}" % ",".join([ C.strip() for C in String[1:-1].split(',')])
+ return "{%s}" % ",".join(C.strip() for C in String[1:-1].split(','))
else:
if len(String.split()) % 2:
|