diff options
| author | zhijufan <zhijux.fan@intel.com> | 2018-09-27 14:08:15 +0800 |
|---|---|---|
| committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-09-30 16:05:49 +0800 |
| commit | c526dcd40f3a0f3a091684481f9c85f03f6a70a7 (patch) | |
| tree | 90991c02eb9127dbb5966867e8b1192b33f01d3c /BaseTools/Source/Python/Common | |
| parent | 5b02be4d9a234d80c7578fc3a0c789d22ce83f38 (diff) | |
| download | edk2-c526dcd40f3a0f3a091684481f9c85f03f6a70a7.tar.gz edk2-c526dcd40f3a0f3a091684481f9c85f03f6a70a7.tar.bz2 edk2-c526dcd40f3a0f3a091684481f9c85f03f6a70a7.zip | |
BaseTools: refactor the error for PCD value is negative or exceed max
refactor the error handling for the PCD value that is negative or it
exceed the max value.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/Common')
| -rw-r--r-- | BaseTools/Source/Python/Common/Misc.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Python/Common/Misc.py index fb6a844dd5..0efd8b05a8 100644 --- a/BaseTools/Source/Python/Common/Misc.py +++ b/BaseTools/Source/Python/Common/Misc.py @@ -1589,8 +1589,12 @@ def CheckPcdDatum(Type, Value): return False, "Invalid value [%s] of type [%s]; must be one of TRUE, True, true, 0x1, 0x01, 1"\
", FALSE, False, false, 0x0, 0x00, 0" % (Value, Type)
elif Type in [TAB_UINT8, TAB_UINT16, TAB_UINT32, TAB_UINT64]:
+ if Value and int(Value, 0) < 0:
+ return False, "PCD can't be set to negative value[%s] for datum type [%s]" % (Value, Type)
try:
Value = long(Value, 0)
+ if Value > MAX_VAL_TYPE[Type]:
+ return False, "Too large PCD value[%s] for datum type [%s]" % (Value, Type)
except:
return False, "Invalid value [%s] of type [%s];"\
" must be a hexadecimal, decimal or octal in C language format." % (Value, Type)
|