BaseTools: drop GeneralCheckNonAscii() from ECC

The GeneralCheckNonAscii() function is a sledgehammer rejecting any file
containing any character outside of the 7-bit ASCII encoding space, as
well as the DEL character (which seems unrelated).

This conflicts with basic stuff like correctly spelling certain proper
nouns in comments (like copyright statements), or string literals (for
example in multi-language driver binding ComponentNames).

So rip it out, to be replaced by more fine-grained checks to be added as
identified and needed.

Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>

1 files changed, 0 insertions, 20 deletions

diff --git a/BaseTools/Source/Python/Ecc/Check.py b/BaseTools/Source/Python/Ecc/Check.py
index 9ca2fa5cec..4561961141 100644
--- a/BaseTools/Source/Python/Ecc/Check.py
+++ b/BaseTools/Source/Python/Ecc/Check.py
@@ -181,7 +181,6 @@ class Check(object):
 

     # General Checking

     def GeneralCheck(self):

-        self.GeneralCheckNonAscii()

         self.UniCheck()

         self.GeneralCheckNoTab()

         self.GeneralCheckLineEnding()

@@ -238,25 +237,6 @@ class Check(object):
                             OtherMsg = "File %s has trailing white spaces at line %s" % (Record[1], IndexOfLine)

                             EccGlobalData.gDb.TblReport.Insert(ERROR_GENERAL_CHECK_TRAILING_WHITE_SPACE_LINE, OtherMsg=OtherMsg, BelongsToTable='File', BelongsToItem=Record[0])

 

-    # Check whether file has non ASCII char

-    def GeneralCheckNonAscii(self):

-        if EccGlobalData.gConfig.GeneralCheckNonAscii == '1' or EccGlobalData.gConfig.GeneralCheckAll == '1' or EccGlobalData.gConfig.CheckAll == '1':

-            EdkLogger.quiet("Checking Non-ASCII char in file ...")

-            SqlCommand = """select ID, FullPath, ExtName from File where ExtName in ('.dec', '.inf', '.dsc', 'c', 'h')"""

-            RecordSet = EccGlobalData.gDb.TblFile.Exec(SqlCommand)

-            for Record in RecordSet:

-                if Record[2].upper() not in EccGlobalData.gConfig.BinaryExtList:

-                    op = open(Record[1]).readlines()

-                    IndexOfLine = 0

-                    for Line in op:

-                        IndexOfLine += 1

-                        IndexOfChar = 0

-                        for Char in Line:

-                            IndexOfChar += 1

-                            if ord(Char) > 126:

-                                OtherMsg = "File %s has Non-ASCII char at line %s column %s" % (Record[1], IndexOfLine, IndexOfChar)

-                                EccGlobalData.gDb.TblReport.Insert(ERROR_GENERAL_CHECK_NON_ASCII, OtherMsg=OtherMsg, BelongsToTable='File', BelongsToItem=Record[0])

-

     # C Function Layout Checking

     def FunctionLayoutCheck(self):

         self.FunctionLayoutCheckReturnType()