summaryrefslogtreecommitdiffstats
path: root/BaseTools/Source/Python/Ecc/MetaDataParser.py
diff options
context:
space:
mode:
authorFoster Nong <foster.nong@intel.com>2022-10-12 10:36:55 +0800
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2022-10-14 07:07:01 +0000
commit4aa7e66c06f8b837845aff2afd7c1c0b35d9afba (patch)
treeb9ad8c914639052fc66bc19317f11ecde0a95720 /BaseTools/Source/Python/Ecc/MetaDataParser.py
parente0200cc47a691291ce1ad0207678a2db12d6503f (diff)
downloadedk2-4aa7e66c06f8b837845aff2afd7c1c0b35d9afba.tar.gz
edk2-4aa7e66c06f8b837845aff2afd7c1c0b35d9afba.tar.bz2
edk2-4aa7e66c06f8b837845aff2afd7c1c0b35d9afba.zip
MdeModulePkg: Fixed extra 1 SR-IOV reserved bus
Below code will calculate the reserved bus number for the each PF. Based on the VF routing ID algorithm, PFRid and LastVF in below code already sure that "All VFs and PFs must have distinct Routing IDs". PF will be assigned Routing ID based on secBusNumber, ReservedBusNum will add into SubBusNumber directly. So the SR-IOV device will be assigned bus range as SecBusNumber ~ (SubBusNumber=(SecBusNumber + ReservedBusNum)). Thus "+1" in below code will cause extra 1 bus, and introduce a bus hole. PFRid = EFI_PCI_RID (Bus, Device, Func); LastVF = PFRid + FirstVFOffset + (PciIoDevice->InitialVFs - 1) * VFStride; PciIoDevice->ReservedBusNum = (UINT16)(EFI_PCI_BUS_OF_RID (LastVF) - Bus + 1); In SR-IOV spec, there is a note in section 2.1.2: Note: Bus Numbers are a constrained resource. Devices are strongly encouraged to avoid leaving ?holes? in their Bus Number usage to avoid wasting Bus Numbers So the issue can be fixed with below code change. PciIoDevice->ReservedBusNum = (UINT16)(EFI_PCI_BUS_OF_RID (LastVF) - Bus); https://bugzilla.tianocore.org/show_bug.cgi?id=4069 Signed-off-by: Foster Nong <foster.nong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/Ecc/MetaDataParser.py')
0 files changed, 0 insertions, 0 deletions