diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2018-07-18 19:38:40 +0200 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2018-08-16 20:02:51 +0200 |
| commit | 9becf2f0759eab29afcb088ee5c49f522d1d6619 (patch) | |
| tree | fc66c154f21e91199fb67f6e72d28240be4111f8 /BaseTools/Source/Python/Eot/EotToolError.py | |
| parent | 15d8fe1fee188cd7a9ce1b0e32cbe34cc93f1097 (diff) | |
| download | edk2-9becf2f0759eab29afcb088ee5c49f522d1d6619.tar.gz edk2-9becf2f0759eab29afcb088ee5c49f522d1d6619.tar.bz2 edk2-9becf2f0759eab29afcb088ee5c49f522d1d6619.zip | |
ShellPkg/UefiShellLib: rebase ShellOpenFileByDevicePath() to UefiLib API
Replace the "old shell method" implementation in
ShellOpenFileByDevicePath() with EfiOpenFileByDevicePath() from UefiLib,
correcting the following issues:
- code duplication between this module and other modules,
- local variable name "EfiSimpleFileSystemProtocol" starting with "Efi"
prefix,
- bogus "FileHandle = NULL" assignments,
- leaking "Handle1" when the device path type/subtype check or the
realignment-motivated AllocateCopyPool() fails in the loop.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1008
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/Eot/EotToolError.py')
0 files changed, 0 insertions, 0 deletions