BaseTools: refactor and remove un-needed use of .keys() on dictionaries

sometimes just delete it.
sometimes the loop needed .values() instead

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/BaseTools/Source/Python/GenFds/CapsuleData.py b/BaseTools/Source/Python/GenFds/CapsuleData.py
index 5b806d9e44..b376d6b2e9 100644
--- a/BaseTools/Source/Python/GenFds/CapsuleData.py
+++ b/BaseTools/Source/Python/GenFds/CapsuleData.py
@@ -1,7 +1,7 @@
 ## @file

 # generate capsule

 #

-#  Copyright (c) 2007-2017, Intel Corporation. All rights reserved.<BR>

+#  Copyright (c) 2007-2018, Intel Corporation. All rights reserved.<BR>

 #

 #  This program and the accompanying materials

 #  are licensed and made available under the terms and conditions of the BSD License

@@ -80,8 +80,8 @@ class CapsuleFv (CapsuleData):
     #

     def GenCapsuleSubItem(self):

         if self.FvName.find('.fv') == -1:

-            if self.FvName.upper() in GenFdsGlobalVariable.FdfParser.Profile.FvDict.keys():

-                FvObj = GenFdsGlobalVariable.FdfParser.Profile.FvDict.get(self.FvName.upper())

+            if self.FvName.upper() in GenFdsGlobalVariable.FdfParser.Profile.FvDict:

+                FvObj = GenFdsGlobalVariable.FdfParser.Profile.FvDict[self.FvName.upper()]

                 FdBuffer = StringIO.StringIO('')

                 FvObj.CapsuleName = self.CapsuleName

                 FvFile = FvObj.AddToBuffer(FdBuffer)

@@ -112,8 +112,8 @@ class CapsuleFd (CapsuleData):
     #

     def GenCapsuleSubItem(self):

         if self.FdName.find('.fd') == -1:

-            if self.FdName.upper() in GenFdsGlobalVariable.FdfParser.Profile.FdDict.keys():

-                FdObj = GenFdsGlobalVariable.FdfParser.Profile.FdDict.get(self.FdName.upper())

+            if self.FdName.upper() in GenFdsGlobalVariable.FdfParser.Profile.FdDict:

+                FdObj = GenFdsGlobalVariable.FdfParser.Profile.FdDict[self.FdName.upper()]

                 FdFile = FdObj.GenFd()

                 return FdFile

         else: