diff options
author | Carsey, Jaben <jaben.carsey@intel.com> | 2018-04-20 23:51:42 +0800 |
---|---|---|
committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-05-02 15:02:20 +0800 |
commit | c93356ada99e6f8083a64f99d162b44a2765ce63 (patch) | |
tree | 1bb64928b259fc66d7e8512a116a758b33a465a1 /BaseTools/Source/Python/GenFds/FfsInfStatement.py | |
parent | 1beb268a686344d92f42ced656edf46c626e9413 (diff) | |
download | edk2-c93356ada99e6f8083a64f99d162b44a2765ce63.tar.gz edk2-c93356ada99e6f8083a64f99d162b44a2765ce63.tar.bz2 edk2-c93356ada99e6f8083a64f99d162b44a2765ce63.zip |
BaseTools: remove redundant if comparison
inherently python will check string and list for None and having data
if <x> in [None, ''] and similar are superflous.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/GenFds/FfsInfStatement.py')
-rw-r--r-- | BaseTools/Source/Python/GenFds/FfsInfStatement.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/BaseTools/Source/Python/GenFds/FfsInfStatement.py b/BaseTools/Source/Python/GenFds/FfsInfStatement.py index 728997f17d..c332eee607 100644 --- a/BaseTools/Source/Python/GenFds/FfsInfStatement.py +++ b/BaseTools/Source/Python/GenFds/FfsInfStatement.py @@ -297,7 +297,7 @@ class FfsInfStatement(FfsInfStatementClassObject): # Check value, if value are equal, no need to patch
if Pcd.DatumType == TAB_VOID:
- if Pcd.InfDefaultValue == DefaultValue or DefaultValue in [None, '']:
+ if Pcd.InfDefaultValue == DefaultValue or not DefaultValue:
continue
# Get the string size from FDF or DSC
if DefaultValue[0] == 'L':
@@ -310,7 +310,7 @@ class FfsInfStatement(FfsInfStatementClassObject): if DscOverride:
Pcd.MaxDatumSize = PatchPcd.MaxDatumSize
# If no defined the maximum size in DSC, try to get current size from INF
- if Pcd.MaxDatumSize in ['', None]:
+ if not Pcd.MaxDatumSize:
Pcd.MaxDatumSize = str(len(Pcd.InfDefaultValue.split(',')))
else:
Base1 = Base2 = 10
|