diff options
| author | Carsey, Jaben </o=Intel/ou=Americas01/cn=Workers/cn=Carsey, Jaben> | 2018-04-13 08:02:10 +0800 |
|---|---|---|
| committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-04-17 20:49:32 +0800 |
| commit | 128d435f5e572733ab2649c4494f5d4f786b6f6b (patch) | |
| tree | 67c27162da6af724a8d93da66946971c3cb1c33b /BaseTools/Source/Python/GenFds | |
| parent | 72fbe88d7290cfc4196658898ea8c5e28d539502 (diff) | |
| download | edk2-128d435f5e572733ab2649c4494f5d4f786b6f6b.tar.gz edk2-128d435f5e572733ab2649c4494f5d4f786b6f6b.tar.bz2 edk2-128d435f5e572733ab2649c4494f5d4f786b6f6b.zip | |
BaseTools: fix None comparisons
when comparing a list/string against None and empty, just compare the object.
when comparing against None, dont use !=, ==, <>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/GenFds')
| -rw-r--r-- | BaseTools/Source/Python/GenFds/Fv.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/BaseTools/Source/Python/GenFds/Fv.py b/BaseTools/Source/Python/GenFds/Fv.py index 345ad3bdcc..aae644bef9 100644 --- a/BaseTools/Source/Python/GenFds/Fv.py +++ b/BaseTools/Source/Python/GenFds/Fv.py @@ -337,11 +337,10 @@ class FV (FvClassObject): #
# Generate FV extension header file
#
- if self.FvNameGuid is None or self.FvNameGuid == '':
+ if not self.FvNameGuid:
if len(self.FvExtEntryType) > 0 or self.UsedSizeEnable:
GenFdsGlobalVariable.ErrorLogger("FV Extension Header Entries declared for %s with no FvNameGuid declaration." % (self.UiFvName))
-
- if self.FvNameGuid <> None and self.FvNameGuid <> '':
+ else:
TotalSize = 16 + 4
Buffer = ''
if self.UsedSizeEnable:
|