diff options
author | Laszlo Ersek <lersek@redhat.com> | 2019-11-21 08:46:10 +0100 |
---|---|---|
committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2019-12-02 19:35:18 +0000 |
commit | b49a6c8f80d970cf7ab25c28a079c0db225f3ad2 (patch) | |
tree | 7c19f41e83fc1a85ef51b837f1cb38cbb2b6249a /BaseTools/Source/Python/Workspace/MetaFileParser.py | |
parent | fe6142f04c4f742f5f1159d50161da8c0ede338c (diff) | |
download | edk2-b49a6c8f80d970cf7ab25c28a079c0db225f3ad2.tar.gz edk2-b49a6c8f80d970cf7ab25c28a079c0db225f3ad2.tar.bz2 edk2-b49a6c8f80d970cf7ab25c28a079c0db225f3ad2.zip |
CryptoPkg/OpensslLib: improve INF file consistency
When diffing "OpensslLib.inf" against "OpensslLibCrypto.inf", the *only*
differences should be:
- BASE_NAME, MODULE_UNI_FILE, and FILE_GUID are expected to differ, in
[Defines];
- "OpensslLib.inf" is expected to list "$(OPENSSL_PATH)/ssl/..." source
files in the auto-generated part of the [Sources] section.
Commit 8906f076de35 ("CryptoPkg/OpensslLib: Add missing header files in
INF file", 2019-08-16) broke that invariant, by adding "buildinf.h" and
"rand_pool_noise.h" in different order to both INF files.
Fix that order in "OpensslLib.inf" now. (Note that this does not
re-establish full consistency between both INF files -- it just highlights
another problem, which we'll fix in the next patch.)
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Shenglei Zhang <shenglei.zhang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Fixes: 8906f076de35b222a7d62bcf6ed1a4a2498a5791
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Diffstat (limited to 'BaseTools/Source/Python/Workspace/MetaFileParser.py')
0 files changed, 0 insertions, 0 deletions