diff options
author | Ray Ni <ray.ni@intel.com> | 2019-10-23 14:54:57 +0800 |
---|---|---|
committer | Ray Ni <ray.ni@intel.com> | 2019-11-05 10:03:44 +0800 |
commit | fe3ca5fd2518e63338c74df05f508fa81baab2d7 (patch) | |
tree | fecd3197eb04bb1337b9e5e00402f017e842c681 /BaseTools/Source/Python/Workspace/MetaFileParser.py | |
parent | 54d1e76f4e17255080f083b155cee8c6678d8175 (diff) | |
download | edk2-fe3ca5fd2518e63338c74df05f508fa81baab2d7.tar.gz edk2-fe3ca5fd2518e63338c74df05f508fa81baab2d7.tar.bz2 edk2-fe3ca5fd2518e63338c74df05f508fa81baab2d7.zip |
UefiCpuPkg/MpInitLib: Remove global variable X2ApicEnable
MpInitLib sets X2ApicEnable in two places.
1. CollectProcessorCount()
This function is called when MpInitLibInitialize() hasn't been
called before.
It sets X2ApicEnable and later in the same function it configures
all CPUs to operate in X2 APIC mode.
2. MpInitLibInitialize()
The X2ApicEnable setting happens when this function is called in
second time. But after that setting, no code consumes that flag.
With the above analysis and with the purpose of simplifying the code,
the X2ApicEnable in #1 is changed to local variable and the #2 can be
changed to remove the setting of X2ApicEnable.
Signed-off-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Diffstat (limited to 'BaseTools/Source/Python/Workspace/MetaFileParser.py')
0 files changed, 0 insertions, 0 deletions