diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2020-01-16 13:23:10 +0100 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2020-01-31 09:35:31 +0000 |
| commit | c602e97446a8e818bf09182f5dc9f3fa409ece95 (patch) | |
| tree | 33fae5162334c34c60db7ccabd65c13ecc4bca4b /BaseTools/Source/Python/Workspace/WorkspaceDatabase.py | |
| parent | 12a4ef58a8b1f8610f6f7cd3ffb973f924f175fb (diff) | |
| download | edk2-c602e97446a8e818bf09182f5dc9f3fa409ece95.tar.gz edk2-c602e97446a8e818bf09182f5dc9f3fa409ece95.tar.bz2 edk2-c602e97446a8e818bf09182f5dc9f3fa409ece95.zip | |
SecurityPkg/DxeImageVerificationHandler: unnest AddImageExeInfo() call
Before the "Done" label at the end of DxeImageVerificationHandler(), we
now have a single access to "Status": we set "Status" to EFI_ACCESS_DENIED
at the top of the function. Therefore, the (Status != EFI_SUCCESS)
condition is always true under the "Done" label.
Accordingly, unnest the AddImageExeInfo() call dependent on that
condition, remove the condition, and also rename the "Done" label to
"Failed".
Functionally, this patch is a no-op. It's easier to review with:
git show -b -W
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20200116190705.18816-8-lersek@redhat.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
[lersek@redhat.com: replace EFI_D_INFO w/ DEBUG_INFO for PatchCheck.py]
[lersek@redhat.com: push with Mike's R-b due to Chinese New Year
Holiday: <https://edk2.groups.io/g/devel/message/53429>; msgid
<d3fbb76dabed4e1987c512c328c82810@intel.com>]
Diffstat (limited to 'BaseTools/Source/Python/Workspace/WorkspaceDatabase.py')
0 files changed, 0 insertions, 0 deletions