diff options
| author | Gary Lin <glin@suse.com> | 2018-06-25 18:31:35 +0800 |
|---|---|---|
| committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-06-27 16:33:27 +0800 |
| commit | 0d1f5b2b5dc3c1cf381be0a1ec8f960dc6029a93 (patch) | |
| tree | 370c6121707d6141988e1795f061e93abc112cbb /BaseTools/gcc | |
| parent | 2617a73c3628473bacea887d885bdd1e7808ccc6 (diff) | |
| download | edk2-0d1f5b2b5dc3c1cf381be0a1ec8f960dc6029a93.tar.gz edk2-0d1f5b2b5dc3c1cf381be0a1ec8f960dc6029a93.tar.bz2 edk2-0d1f5b2b5dc3c1cf381be0a1ec8f960dc6029a93.zip | |
BaseTools: Fix old python2 idioms
Based on "futurize -f lib2to3.fixes.fix_idioms"
* Change some type comparisons to isinstance() calls:
type(x) == T -> isinstance(x, T)
type(x) is T -> isinstance(x, T)
type(x) != T -> not isinstance(x, T)
type(x) is not T -> not isinstance(x, T)
* Change "while 1:" into "while True:".
* Change both
v = list(EXPR)
v.sort()
foo(v)
and the more general
v = EXPR
v.sort()
foo(v)
into
v = sorted(EXPR)
foo(v)
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/gcc')
| -rwxr-xr-x | BaseTools/gcc/mingw-gcc-build.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/BaseTools/gcc/mingw-gcc-build.py b/BaseTools/gcc/mingw-gcc-build.py index 43f57af903..e940cdb73f 100755 --- a/BaseTools/gcc/mingw-gcc-build.py +++ b/BaseTools/gcc/mingw-gcc-build.py @@ -257,9 +257,9 @@ class SourceFiles: replaceables = ('extract-dir', 'filename', 'url') for replaceItem in fdata: if replaceItem in replaceables: continue - if type(fdata[replaceItem]) != str: continue + if not isinstance(fdata[replaceItem], str): continue
for replaceable in replaceables: - if type(fdata[replaceable]) != str: continue + if not isinstance(fdata[replaceable], str): continue
if replaceable in fdata: fdata[replaceable] = \ fdata[replaceable].replace( |