diff options
| author | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-03-02 23:07:06 +0800 |
|---|---|---|
| committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-03-03 15:41:16 +0800 |
| commit | 27db236ac2beefc8a2de4c0df07ab47374aacfc3 (patch) | |
| tree | 80e4411e93533551aa675723a645e6fb006ad277 /BaseTools | |
| parent | c1d6749b0ed3c58b7dc771e0f857995096107f44 (diff) | |
| download | edk2-27db236ac2beefc8a2de4c0df07ab47374aacfc3.tar.gz edk2-27db236ac2beefc8a2de4c0df07ab47374aacfc3.tar.bz2 edk2-27db236ac2beefc8a2de4c0df07ab47374aacfc3.zip | |
BaseTools: Fix byte orders when handling 8-byte array
Per UEFI spec, FibreEx.WWN, FibreEx.Lun, SasEx.Address, SasEx.Lun
and iSCSI.Lun are all 8-byte array with byte #0 in the left.
It means "0102030405060708" should be converted to:
UINT8[8] = {01, 02, 03, 04, 05, 06, 07, 08}
or UINT64 = {0807060504030201}
Today's implementation wrongly uses the reversed order.
The patch fixes this issue by using StrHexToBytes().
Copy this solution from MdePkg Hash version d0196be.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Diffstat (limited to 'BaseTools')
| -rw-r--r-- | BaseTools/Source/C/DevicePath/DevicePathFromText.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/BaseTools/Source/C/DevicePath/DevicePathFromText.c b/BaseTools/Source/C/DevicePath/DevicePathFromText.c index fd310c7d0f..bfd91d23b5 100644 --- a/BaseTools/Source/C/DevicePath/DevicePathFromText.c +++ b/BaseTools/Source/C/DevicePath/DevicePathFromText.c @@ -2387,6 +2387,7 @@ DevPathFromTextiSCSI ( CHAR16 *ProtocolStr;
CHAR8 *AsciiStr;
ISCSI_DEVICE_PATH_WITH_NAME *ISCSIDevPath;
+ UINT64 Lun;
NameStr = GetNextParamStr (&TextDeviceNode);
PortalGroupStr = GetNextParamStr (&TextDeviceNode);
@@ -2405,7 +2406,8 @@ DevPathFromTextiSCSI ( StrToAscii (NameStr, &AsciiStr);
ISCSIDevPath->TargetPortalGroupTag = (UINT16) Strtoi (PortalGroupStr);
- Strtoi64 (LunStr, &ISCSIDevPath->Lun);
+ Strtoi64 (LunStr, &Lun);
+ WriteUnaligned64 ((UINT64 *) &ISCSIDevPath->Lun, SwapBytes64 (Lun));
Options = 0x0000;
if (StrCmp (HeaderDigestStr, L"CRC32C") == 0) {
|