diff options
author | Hao Wu <hao.a.wu@intel.com> | 2018-08-16 09:32:10 +0800 |
---|---|---|
committer | Hao Wu <hao.a.wu@intel.com> | 2018-08-21 16:10:42 +0800 |
commit | 02f7fd158e977d0368705129c52a800217fe8887 (patch) | |
tree | f3ee24c73747775d12d32878701621481a25360f /BaseTools | |
parent | 6cf6fed02408b5f3ba39de46cbc971b9dda3639b (diff) | |
download | edk2-02f7fd158e977d0368705129c52a800217fe8887.tar.gz edk2-02f7fd158e977d0368705129c52a800217fe8887.tar.bz2 edk2-02f7fd158e977d0368705129c52a800217fe8887.zip |
UefiCpuPkg/PiSmmCpuDxeSmm: [CVE-2017-5715] Stuff RSB before RSM
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1093
Return Stack Buffer (RSB) is used to predict the target of RET
instructions. When the RSB underflows, some processors may fall back to
using branch predictors. This might impact software using the retpoline
mitigation strategy on those processors.
This commit will add RSB stuffing logic before returning from SMM (the RSM
instruction) to avoid interfering with non-SMM usage of the retpoline
technique.
After the stuffing, RSB entries will contain a trap like:
@SpecTrap:
pause
lfence
jmp @SpecTrap
A more detailed explanation of the purpose of commit is under the
'Branch target injection mitigation' section of the below link:
https://software.intel.com/security-software-guidance/insights/host-firmware-speculative-execution-side-channel-mitigation
Please note that this commit requires further actions (BZ 1091) to remove
the duplicated 'StuffRsb.inc' files and merge them into one under a
UefiCpuPkg package-level directory (such as UefiCpuPkg/Include/).
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1091
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Diffstat (limited to 'BaseTools')
0 files changed, 0 insertions, 0 deletions