diff options
author | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-07-09 20:14:38 +0800 |
---|---|---|
committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-07-10 16:01:09 +0800 |
commit | 9edba51f93d8e81e09f905afc994efe02dbe524e (patch) | |
tree | 22575e3f7761fe82f3e3501fbee792b406623189 /BaseTools | |
parent | d7634dc0c5a83360b3b6c155df29c078ad9c77ce (diff) | |
download | edk2-9edba51f93d8e81e09f905afc994efe02dbe524e.tar.gz edk2-9edba51f93d8e81e09f905afc994efe02dbe524e.tar.bz2 edk2-9edba51f93d8e81e09f905afc994efe02dbe524e.zip |
BaseTools: Fix the bug that incorrect size info in the Lib autogen
The case is a PCD used in one library only, and in DSC component
section the PCD value is override in one of module inf. Then it cause
the bug the PCD size in the Lib autogen use the PCD value in the DSC
PCD section, but not use the override value.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Diffstat (limited to 'BaseTools')
-rw-r--r-- | BaseTools/Source/Python/AutoGen/AutoGen.py | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index d100648606..b27290989e 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -1293,12 +1293,17 @@ class PlatformAutoGen(AutoGen): ShareFixedAtBuildPcdsSameValue = {}
for Module in LibAuto._ReferenceModules:
for Pcd in Module.FixedAtBuildPcds + LibAuto.FixedAtBuildPcds:
+ DefaultValue = Pcd.DefaultValue
+ # Cover the case: DSC component override the Pcd value and the Pcd only used in one Lib
+ if Pcd in Module.LibraryPcdList:
+ Index = Module.LibraryPcdList.index(Pcd)
+ DefaultValue = Module.LibraryPcdList[Index].DefaultValue
key = ".".join((Pcd.TokenSpaceGuidCName, Pcd.TokenCName))
if key not in FixedAtBuildPcds:
ShareFixedAtBuildPcdsSameValue[key] = True
- FixedAtBuildPcds[key] = Pcd.DefaultValue
+ FixedAtBuildPcds[key] = DefaultValue
else:
- if FixedAtBuildPcds[key] != Pcd.DefaultValue:
+ if FixedAtBuildPcds[key] != DefaultValue:
ShareFixedAtBuildPcdsSameValue[key] = False
for Pcd in LibAuto.FixedAtBuildPcds:
key = ".".join((Pcd.TokenSpaceGuidCName, Pcd.TokenCName))
|