diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2018-03-31 22:25:15 +0200 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2018-04-13 14:06:21 +0200 |
| commit | a347b0897384a2af6605bdd19a7740972b73f1e7 (patch) | |
| tree | c5203a41bec7e0397b6ec3188bc4ac1470331806 /CryptoPkg | |
| parent | 96015d5fc51f6c81902a212662c73b512b0c8535 (diff) | |
| download | edk2-a347b0897384a2af6605bdd19a7740972b73f1e7.tar.gz edk2-a347b0897384a2af6605bdd19a7740972b73f1e7.tar.bz2 edk2-a347b0897384a2af6605bdd19a7740972b73f1e7.zip | |
CryptoPkg/TlsLib: sanitize lib classes in internal header and INF
"InternalTlsLib.h" includes "BaseCryptLib.h", but the lib class is not
listed in the INF file.
The INF file lists a good number of lib classes, but none of the lib class
headers are included by "InternalTlsLib.h".
Synchronize & sort both lists, while removing those library classes that
aren't actually needed. (IntrinsicLib and OpensslLib have no edk2 class
headers.)
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Qin Long <qin.long@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Ting Ye <ting.ye@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=915
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Long Qin <qin.long@intel.com>
Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
Diffstat (limited to 'CryptoPkg')
| -rw-r--r-- | CryptoPkg/Library/TlsLib/InternalTlsLib.h | 3 | ||||
| -rw-r--r-- | CryptoPkg/Library/TlsLib/TlsLib.inf | 6 |
2 files changed, 5 insertions, 4 deletions
diff --git a/CryptoPkg/Library/TlsLib/InternalTlsLib.h b/CryptoPkg/Library/TlsLib/InternalTlsLib.h index 88c4e3b38e..3f18a461a8 100644 --- a/CryptoPkg/Library/TlsLib/InternalTlsLib.h +++ b/CryptoPkg/Library/TlsLib/InternalTlsLib.h @@ -19,6 +19,9 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #undef _WIN64
#include <Library/BaseCryptLib.h>
+#include <Library/BaseLib.h>
+#include <Library/BaseMemoryLib.h>
+#include <Library/DebugLib.h>
#include <openssl/ssl.h>
#include <openssl/bio.h>
#include <openssl/err.h>
diff --git a/CryptoPkg/Library/TlsLib/TlsLib.inf b/CryptoPkg/Library/TlsLib/TlsLib.inf index a3f93e7165..ae17a7d874 100644 --- a/CryptoPkg/Library/TlsLib/TlsLib.inf +++ b/CryptoPkg/Library/TlsLib/TlsLib.inf @@ -39,14 +39,12 @@ CryptoPkg/CryptoPkg.dec
[LibraryClasses]
+ BaseCryptLib
BaseLib
BaseMemoryLib
- MemoryAllocationLib
- UefiRuntimeServicesTableLib
DebugLib
- OpensslLib
IntrinsicLib
- PrintLib
+ OpensslLib
[BuildOptions]
#
|