summaryrefslogtreecommitdiffstats
path: root/EdkShellPkg
diff options
context:
space:
mode:
authorLaszlo Ersek <lersek@redhat.com>2017-05-05 03:31:32 +0200
committerLaszlo Ersek <lersek@redhat.com>2017-05-18 10:12:58 +0200
commit62f43f7c1947c799dd69fb4b2d94376b8e689b51 (patch)
tree5b8666a7bf592ae4608a5a411c8edf125bcca538 /EdkShellPkg
parentc15c1c086325efd9b50ca754e44a52501d5fc5ca (diff)
downloadedk2-62f43f7c1947c799dd69fb4b2d94376b8e689b51.tar.gz
edk2-62f43f7c1947c799dd69fb4b2d94376b8e689b51.tar.bz2
edk2-62f43f7c1947c799dd69fb4b2d94376b8e689b51.zip
OvmfPkg: sync PcdVariableStoreSize with PcdFlashNvStorageVariableSize
"MdeModulePkg/MdeModulePkg.dec" declares PcdVariableStoreSize like this: > The size of volatile buffer. This buffer is used to store VOLATILE > attribute variables. There is no inherent reason why the size of the volatile variable store should match the same of the non-volatile variable store. Indeed flash variables in the 4MB build work fine without this equality. However, OvmfPkg/EmuVariableFvbRuntimeDxe uses PcdVariableStoreSize to initialize the non-volatile VARIABLE_STORE_HEADER too. (Presumably based on the fact that ultimately that storage will not be permanent.) When using EmuVariableFvbRuntimeDxe in the 4MB build, the mismatch between the two mentioned PCDs (which is apparent through EmuVariableFvbRuntimeDxe's VARIABLE_STORE_HEADER) triggers an assertion in the variable driver: > ASSERT MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c(3772): > mNvVariableCache->Size == VariableStoreLength Bringing PcdVariableStoreSize in sync with PcdFlashNvStorageVariableSize fixes this. It also happens to ensure a volatile store size in the 4MB build that equals the non-volatile store size, which likely doesn't hurt for symmetry. Cc: Jordan Justen <jordan.l.justen@intel.com> Fixes: b24fca05751f8222acf264853709012e0ab7bf49 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Diffstat (limited to 'EdkShellPkg')
0 files changed, 0 insertions, 0 deletions