IntelFrameworkModule/ThunkKb: ReadKeyStrokeEx always return key state

Today's implementation only return key state when there is a key.
But when user doesn't press any key, the key state cannot be
returned.

The patch changes the ReadKeyStrokeEx() to always return the
key state even there is no key pressed.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>

1 files changed, 12 insertions, 2 deletions

diff --git a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c
index ec525891dc..ac8e2364c8 100644
--- a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c
+++ b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c
@@ -1,7 +1,7 @@
 /** @file

   ConsoleOut Routines that speak VGA.

 

-Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>

 

 This program and the accompanying materials

 are licensed and made available under the terms and conditions

@@ -269,7 +269,9 @@ BiosKeyboardDriverBindingStart (
   BiosKeyboardPrivate->StatusRegisterAddress      = KEYBOARD_8042_STATUS_REGISTER;

   BiosKeyboardPrivate->CommandRegisterAddress     = KEYBOARD_8042_COMMAND_REGISTER;

   BiosKeyboardPrivate->ExtendedKeyboard           = TRUE;

-  

+

+  BiosKeyboardPrivate->KeyState.KeyShiftState     = 0;

+  BiosKeyboardPrivate->KeyState.KeyToggleState    = 0;

   BiosKeyboardPrivate->Queue.Front                = 0;

   BiosKeyboardPrivate->Queue.Rear                 = 0;

   BiosKeyboardPrivate->QueueForNotify.Front       = 0;

@@ -978,6 +980,8 @@ KeyboardReadKeyStrokeWorker (
   //

   Status = CheckQueue (&BiosKeyboardPrivate->Queue);

   if (EFI_ERROR (Status)) {

+    ZeroMem (&KeyData->Key, sizeof (KeyData->Key));

+    CopyMem (&KeyData->KeyState, &BiosKeyboardPrivate->KeyState, sizeof (EFI_KEY_STATE));

     gBS->RestoreTPL (OldTpl);

     return EFI_NOT_READY;

   }

@@ -1986,6 +1990,12 @@ BiosKeyboardTimerHandler (
   }

 

   Enqueue (&BiosKeyboardPrivate->Queue, &KeyData);

+

+  //

+  // Save the current key state

+  //

+  CopyMem (&BiosKeyboardPrivate->KeyState, &KeyData.KeyState, sizeof (EFI_KEY_STATE));

+

   //

   // Leave critical section and return

   //