diff options
author | Chasel Chiu <chasel.chiu@intel.com> | 2019-10-25 15:46:19 +0800 |
---|---|---|
committer | Chasel Chiu <chasel.chiu@intel.com> | 2019-10-28 10:28:56 +0800 |
commit | 9e639c1cb6abd5ffed0f9017de26f93d2ee99eac (patch) | |
tree | 67d813762cdd01886ec26c7fced036176a95a3d1 /Maintainers.txt | |
parent | 6996ec88a244a2428beb81d126ee55d152f62a07 (diff) | |
download | edk2-9e639c1cb6abd5ffed0f9017de26f93d2ee99eac.tar.gz edk2-9e639c1cb6abd5ffed0f9017de26f93d2ee99eac.tar.bz2 edk2-9e639c1cb6abd5ffed0f9017de26f93d2ee99eac.zip |
IntelFsp2Pkg/SplitFspBin.py: Command crashed when FV almost full.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2310
When target FV 99% used and only few bytes space left,
SplitFspBin.py may crash with below error:
File "SplitFspBin.py", line 457, in ParseFv
ffshdr = EFI_FFS_FILE_HEADER.from_buffer (self.FvData, offset)
ValueError: Buffer size too small
(40960 instead of at least 40968 bytes)
It was because the offset used by FFS_HEADER parser out of bounds.
It should stop parsing when offset equal or larger than
(buffer size - FFS_HEADER size).
This patch also fixed another crash issue when running script with
Python 3.x and no input parameter given:
File "SplitFspBin.py", line 868, in main
if args.which in ['rebase', 'split', 'genhdr', 'info']:
AttributeError: 'Namespace' object has no attribute 'which'
Test:
1. Ran script with both py2 and py3 with no input and no crash observed.
2. Compare the script result before and after the patch are identical.
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Diffstat (limited to 'Maintainers.txt')
0 files changed, 0 insertions, 0 deletions