summaryrefslogtreecommitdiffstats
path: root/MdeModulePkg/Bus/Pci/UhciDxe/UsbHcMem.c
diff options
context:
space:
mode:
authorRanbir Singh <Ranbir.Singh3@Dell.com>2023-08-16 13:38:02 +0800
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2023-09-22 04:56:35 +0000
commite9f5d8c0e066da55b3f79dfdbf4df5fc97ca5916 (patch)
tree6f364c8809961e8320f7b01cdc92944f18504a00 /MdeModulePkg/Bus/Pci/UhciDxe/UsbHcMem.c
parentf67e1934d985dcb8a465dcf44484be3688be99a5 (diff)
downloadedk2-e9f5d8c0e066da55b3f79dfdbf4df5fc97ca5916.tar.gz
edk2-e9f5d8c0e066da55b3f79dfdbf4df5fc97ca5916.tar.bz2
edk2-e9f5d8c0e066da55b3f79dfdbf4df5fc97ca5916.zip
MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT Coverity issue
The function UhciConvertPollRate has a check ASSERT (Interval != 0); but this comes into play only in DEBUG mode. In Release mode, there is no handling if the Interval parameter value is ZERO. To avoid shifting by a negative amount later in the code flow in this undesirable case, it is better to handle it as well by treating it same as if 1 is sent. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4211 Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Co-authored-by: Veeresh Sangolli <veeresh.sangolli@dellteam.com> Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com> Signed-off-by: Ranbir Singh <rsingh@ventanamicro.com> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Diffstat (limited to 'MdeModulePkg/Bus/Pci/UhciDxe/UsbHcMem.c')
0 files changed, 0 insertions, 0 deletions