diff options
author | Bret Barkelew <Bret.Barkelew@microsoft.com> | 2019-03-22 11:07:18 +0800 |
---|---|---|
committer | Liming Gao <liming.gao@intel.com> | 2019-04-02 12:49:03 +0800 |
commit | 9338e230178599491a2de28ecaea8c6383eceeaf (patch) | |
tree | c36acd54e2a7fd35ece08da44e0c89a48a6c30f9 /MdeModulePkg/Universal | |
parent | a89fd3a359b868e619355dbeda14ac4104b467a6 (diff) | |
download | edk2-9338e230178599491a2de28ecaea8c6383eceeaf.tar.gz edk2-9338e230178599491a2de28ecaea8c6383eceeaf.tar.bz2 edk2-9338e230178599491a2de28ecaea8c6383eceeaf.zip |
MdeModulePkg/ResetSystemRuntimeDxe: Remove DoS3 in warm reset
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1462
Original logic is that checking the CapsuleUpdate variable
and do the EnterS3WithImmediateWake if the system require a
capsule update. The EnterS3WithImmediateWake is usually
implemented in Platform ResetSystemLib instance and it may
do some operation for capsule update. For now, thess preparations
of capsule are platform reset notify functions' duty. Most
platforms need flush cache to memory before warm reset during
capsule update and this operation is added to capsule flow.
So it is safe to remove it and do not affect the capsule update
function.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Diffstat (limited to 'MdeModulePkg/Universal')
-rw-r--r-- | MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 38 |
1 files changed, 0 insertions, 38 deletions
diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c index 4c7107faea..36234f4d5b 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c @@ -207,22 +207,6 @@ InitializeResetSystem ( }
/**
- Put the system into S3 power state.
-**/
-VOID
-DoS3 (
- VOID
- )
-{
- EnterS3WithImmediateWake ();
-
- //
- // Should not return
- //
- CpuDeadLoop ();
-}
-
-/**
Resets the entire platform.
@param[in] ResetType The type of reset to perform.
@@ -249,9 +233,6 @@ RuntimeServiceResetSystem ( IN VOID *ResetData OPTIONAL
)
{
- EFI_STATUS Status;
- UINTN Size;
- UINTN CapsuleDataPtr;
LIST_ENTRY *Link;
RESET_NOTIFY_ENTRY *Entry;
@@ -315,25 +296,6 @@ RuntimeServiceResetSystem ( switch (ResetType) {
case EfiResetWarm:
- //
- //Check if there are pending capsules to process
- //
- Size = sizeof (CapsuleDataPtr);
- Status = EfiGetVariable (
- EFI_CAPSULE_VARIABLE_NAME,
- &gEfiCapsuleVendorGuid,
- NULL,
- &Size,
- (VOID *) &CapsuleDataPtr
- );
-
- if (Status == EFI_SUCCESS) {
- //
- //Process capsules across a system reset.
- //
- DoS3();
- }
-
ResetWarm ();
break;
|