summaryrefslogtreecommitdiffstats
path: root/MdeModulePkg
diff options
context:
space:
mode:
authorDandan Bi <dandan.bi@intel.com>2016-11-15 19:13:33 +0800
committerStar Zeng <star.zeng@intel.com>2016-11-25 11:00:22 +0800
commit0c01c6713506249cb53c436965d036871736e19e (patch)
treeb54874410c2267c34de49ed55a530708b8265e75 /MdeModulePkg
parentd32d0a244d36ff61da4e8bb75d67424ad9550067 (diff)
downloadedk2-0c01c6713506249cb53c436965d036871736e19e.tar.gz
edk2-0c01c6713506249cb53c436965d036871736e19e.tar.bz2
edk2-0c01c6713506249cb53c436965d036871736e19e.zip
MdeModulePkg/SetupBrowser:Don't support password without interactive flag
In current SetupBrowser, the logic related to non-interative password is not correct. How to support it correctly or whether support it is still under investigation. First step remove the incorrect logic. Cc: Liming Gao <liming.gao@intel.com> Cc: Eric Dong <eric.dong@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi <dandan.bi@intel.com> Reviewed-by: Liming Gao <liming.gao@intel.com> (cherry picked from commit 9e2462b8a28b09738a3177e1694867ca114cc185)
Diffstat (limited to 'MdeModulePkg')
-rw-r--r--MdeModulePkg/Universal/SetupBrowserDxe/Setup.c23
1 files changed, 2 insertions, 21 deletions
diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
index cc9896959b..a2e23d4fb5 100644
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
@@ -5782,29 +5782,10 @@ PasswordCheck (
return EFI_UNSUPPORTED;
}
} else {
- if (PasswordString == NULL) {
- return EFI_SUCCESS;
- }
-
- //
- // Check whether has preexisted password.
- //
- if (PasswordString[0] == 0) {
- if (*((CHAR16 *) Question->BufferValue) == 0) {
- return EFI_SUCCESS;
- } else {
- return EFI_NOT_READY;
- }
- }
-
//
- // Check whether the input password is same as preexisted password.
+ // If a password doesn't have the CALLBACK flag, browser will not handle it.
//
- if (StrnCmp (PasswordString, (CHAR16 *) Question->BufferValue, Question->StorageWidth/sizeof (CHAR16)) == 0) {
- return EFI_SUCCESS;
- } else {
- return EFI_NOT_READY;
- }
+ return EFI_UNSUPPORTED;
}
//