diff options
| author | yshang1 <yshang1@6f19259b-4bc3-4df7-8a09-765794883524> | 2007-08-15 06:17:29 +0000 |
|---|---|---|
| committer | yshang1 <yshang1@6f19259b-4bc3-4df7-8a09-765794883524> | 2007-08-15 06:17:29 +0000 |
| commit | cdebf6c68a11e3e41943825049d415c64e49555a (patch) | |
| tree | 6a5c7aeda6c4ce90864eb1791e82bc9d182455c6 /MdePkg/Include/Base.h | |
| parent | 9833aeafa36e50e88765ab8d67251e748db347ba (diff) | |
| download | edk2-cdebf6c68a11e3e41943825049d415c64e49555a.tar.gz edk2-cdebf6c68a11e3e41943825049d415c64e49555a.tar.bz2 edk2-cdebf6c68a11e3e41943825049d415c64e49555a.zip | |
1) Add type casting for argument "a" in EFI_ERROR(a), since if compare two constants without specify data type, compiler maybe could not understand what is the actual data type of constant. The default would treat it as unsigned data. therefore, if the argument a of EFI_ERROR(a) is constant, for instance the EFI_LOAD_ERROR, the EFI_ERROR(a) would always be FALSE.
2) Remove PcdDriverPcdLibNull.
3) Add more ASSERT() in BasePcdLibNull to detect the incorrect usage of Pcd Library.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3643 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'MdePkg/Include/Base.h')
| -rw-r--r-- | MdePkg/Include/Base.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 15ee9ad89a..c5cf6f38d5 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.h @@ -261,7 +261,7 @@ typedef INTN RETURN_STATUS; #define ENCODE_ERROR(a) (MAX_BIT | (a))
#define ENCODE_WARNING(a) (a)
-#define RETURN_ERROR(a) ((a) < 0)
+#define RETURN_ERROR(a) ((INTN) (a) < 0)
#define RETURN_SUCCESS 0
#define RETURN_LOAD_ERROR ENCODE_ERROR (1)
|