diff options
| author | Zhang, Lubo <lubo.zhang@intel.com> | 2016-07-08 15:50:46 +0800 |
|---|---|---|
| committer | Hao Wu <hao.a.wu@intel.com> | 2016-07-13 09:27:27 +0800 |
| commit | 6a42c5a71606bd98ee3d97aa7c9185d454bb73f9 (patch) | |
| tree | f4f03f956b94decccfa0ae5b35974c14f60b8142 /NetworkPkg/IScsiDxe/IScsiConfig.c | |
| parent | bab57374fb8237add3c51b37b81daa7c631660ef (diff) | |
| download | edk2-6a42c5a71606bd98ee3d97aa7c9185d454bb73f9.tar.gz edk2-6a42c5a71606bd98ee3d97aa7c9185d454bb73f9.tar.bz2 edk2-6a42c5a71606bd98ee3d97aa7c9185d454bb73f9.zip | |
NetworkPkg: Fix Assert issue in iSCSI driver.
The bug existed in replacing AsciiStrToUnicodeStr with AsciiStrToUnicodeStrS,
since MacString now is a pointer, the value sizeof(MacString)/sizeof (MacString[0])
is not correct here as the third parameter.
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Reviewed-By: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
(cherry picked from commit b522ca0cf5ab1f272fcfb7f20b487d47bbf480c4)
Diffstat (limited to 'NetworkPkg/IScsiDxe/IScsiConfig.c')
| -rw-r--r-- | NetworkPkg/IScsiDxe/IScsiConfig.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiConfig.c index a82ce231e8..a523e10306 100644 --- a/NetworkPkg/IScsiDxe/IScsiConfig.c +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c @@ -687,7 +687,7 @@ IScsiConvertIfrNvDataToAttemptConfigData ( return EFI_OUT_OF_RESOURCES;
}
- AsciiStrToUnicodeStrS (Attempt->MacString, MacString, sizeof (MacString) / sizeof (MacString[0]));
+ AsciiStrToUnicodeStrS (Attempt->MacString, MacString, ISCSI_MAX_MAC_STRING_LEN);
UnicodeSPrint (
mPrivate->PortString,
|