diff options
author | Laszlo Ersek <lersek@redhat.com> | 2021-05-26 22:14:39 +0200 |
---|---|---|
committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2021-06-04 16:01:50 +0000 |
commit | 7e25086a0076fcf2bc2cbef01995f034215c209f (patch) | |
tree | e51397d2127b44526216dd9dca49a2254800b5f2 /OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | |
parent | 8af38170b5c96cff63ee653fe38038466d2c7293 (diff) | |
download | edk2-7e25086a0076fcf2bc2cbef01995f034215c209f.tar.gz edk2-7e25086a0076fcf2bc2cbef01995f034215c209f.tar.bz2 edk2-7e25086a0076fcf2bc2cbef01995f034215c209f.zip |
OvmfPkg/SmbiosPlatformDxe: clean up #includes and INF
- Sort all sections in the INF file.
- Remove unused packages (MdeModulePkg) and lib classes (BaseMemoryLib)
from the INF file.
- Restrict some lib classes (BaseLib, HobLib) and GUIDs (gEfiXenInfoGuid)
to IA32 and X64, in the INF file; only the IA32/X64 Xen implementation
requires these.
- Don't make "SmbiosPlatformDxe.h" #include everything just as a
convenience. Spell out directly needed #includes in every file (annotate
each with an example identifier consumed), drop unused #includes.
- Keep #includes sorted.
- Remove the leading underscore from the #include guard macro name in
"SmbiosPlatformDxe.h".
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien@xen.org>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20210526201446.12554-37-lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf')
-rw-r--r-- | OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf index 8b56d90cf8..6063c0c9f6 100644 --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf @@ -24,9 +24,9 @@ #
[Sources]
- SmbiosPlatformDxe.h
- SmbiosPlatformDxe.c
Qemu.c
+ SmbiosPlatformDxe.c
+ SmbiosPlatformDxe.h
[Sources.IA32, Sources.X64]
X86Xen.c
@@ -36,19 +36,19 @@ [Packages]
MdePkg/MdePkg.dec
- MdeModulePkg/MdeModulePkg.dec
OvmfPkg/OvmfPkg.dec
[LibraryClasses]
- UefiBootServicesTableLib
- BaseMemoryLib
- BaseLib
- UefiDriverEntryPoint
DebugLib
- HobLib
- QemuFwCfgLib
MemoryAllocationLib
PcdLib
+ QemuFwCfgLib
+ UefiBootServicesTableLib
+ UefiDriverEntryPoint
+
+[LibraryClasses.IA32, LibraryClasses.X64]
+ BaseLib
+ HobLib
[Pcd]
gUefiOvmfPkgTokenSpaceGuid.PcdQemuSmbiosValidated
@@ -56,7 +56,7 @@ [Protocols]
gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED
-[Guids]
+[Guids.IA32, Guids.X64]
gEfiXenInfoGuid
[Depex]
|