diff options
author | Laszlo Ersek <lersek@redhat.com> | 2021-05-26 22:14:40 +0200 |
---|---|---|
committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2021-06-04 16:01:50 +0000 |
commit | 507259373828ca160dea08fff8ffc44572e8be14 (patch) | |
tree | f12d438b1d64bafc11b725b48d7fc970c7c69b64 /OvmfPkg/SmbiosPlatformDxe | |
parent | 7e25086a0076fcf2bc2cbef01995f034215c209f (diff) | |
download | edk2-507259373828ca160dea08fff8ffc44572e8be14.tar.gz edk2-507259373828ca160dea08fff8ffc44572e8be14.tar.bz2 edk2-507259373828ca160dea08fff8ffc44572e8be14.zip |
OvmfPkg/SmbiosPlatformDxe: return EFI_NOT_FOUND if there is no SMBIOS data
According to the function-top comment, SmbiosTablePublishEntry() is
supposed to return an error code if no SMBIOS data is found, from either
GetXenSmbiosTables() or GetQemuSmbiosTables(). Currently the function
returns EFI_SUCCESS in this case however (propagated from
gBS->LocateProtocol()). Make the return code match the documentation.
(This issue is not too important, but it gets in the way of splitting the
entry point function next.)
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20210526201446.12554-38-lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'OvmfPkg/SmbiosPlatformDxe')
-rw-r--r-- | OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c index 9bfc9f14f1..6d73173aa5 100644 --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c @@ -192,6 +192,7 @@ SmbiosTablePublishEntry ( return Status;
}
+ Status = EFI_NOT_FOUND;
//
// Add Xen or QEMU SMBIOS data if found
//
|