summaryrefslogtreecommitdiffstats
path: root/OvmfPkg/XenBusDxe
diff options
context:
space:
mode:
authorAnthony PERARD <anthony.perard@citrix.com>2019-07-01 12:14:03 +0100
committerLaszlo Ersek <lersek@redhat.com>2019-07-01 16:46:51 +0200
commit6a1f06fadb26c342205cf9edeba7e67e92e2135b (patch)
treed06336adc968071e34c95ff1271dfca2cf8b2fc4 /OvmfPkg/XenBusDxe
parent64ef66ba8b4120f4958dc0275911e10eb927d311 (diff)
downloadedk2-6a1f06fadb26c342205cf9edeba7e67e92e2135b.tar.gz
edk2-6a1f06fadb26c342205cf9edeba7e67e92e2135b.tar.bz2
edk2-6a1f06fadb26c342205cf9edeba7e67e92e2135b.zip
OvmfPkg/XenBusDxe: Don't call DisconnectController in Stop()
Calling DisconnectController() on children isn't part of the job of EFI_DRIVER_BINDING_PROTOCOL.Stop() as it only needs to deallocate resources allocated in Start(). The disconnection will happen when both DevicePath and XenBus protocols gets uninstalled. Reported-by: Laszlo Ersek <lersek@redhat.com> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Message-Id: <20190701111403.7007-1-anthony.perard@citrix.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Diffstat (limited to 'OvmfPkg/XenBusDxe')
-rw-r--r--OvmfPkg/XenBusDxe/XenBusDxe.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/OvmfPkg/XenBusDxe/XenBusDxe.c b/OvmfPkg/XenBusDxe/XenBusDxe.c
index 7c07a96650..634c7b71eb 100644
--- a/OvmfPkg/XenBusDxe/XenBusDxe.c
+++ b/OvmfPkg/XenBusDxe/XenBusDxe.c
@@ -446,12 +446,6 @@ XenBusDxeDriverBindingStop (
continue;
}
ChildData = XENBUS_PRIVATE_DATA_FROM_THIS (XenBusIo);
- Status = gBS->DisconnectController (ChildData->Handle, NULL, NULL);
- if (EFI_ERROR (Status)) {
- DEBUG ((EFI_D_ERROR, "XenBusDxe: error disconnecting child: %r\n",
- Status));
- continue;
- }
Status = gBS->CloseProtocol (Dev->ControllerHandle, &gXenIoProtocolGuid,
Dev->This->DriverBindingHandle, ChildData->Handle);