diff options
| author | Jeff Fan <jeff.fan@intel.com> | 2016-09-20 16:03:18 +0800 |
|---|---|---|
| committer | Jeff Fan <jeff.fan@intel.com> | 2016-09-21 14:12:40 +0800 |
| commit | 26ea0da235fe4082ef338f37d7ac292ce259c586 (patch) | |
| tree | c4de62d200643d64167731055b2f8391c76acccc /QuarkPlatformPkg | |
| parent | 1f87985ab7958664a84da78095b5892f88acf3f1 (diff) | |
| download | edk2-26ea0da235fe4082ef338f37d7ac292ce259c586.tar.gz edk2-26ea0da235fe4082ef338f37d7ac292ce259c586.tar.bz2 edk2-26ea0da235fe4082ef338f37d7ac292ce259c586.zip | |
QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S
ESP should be set to top of eSRAM range that aligns with Flat32.asm. Because CPU
BIST data will be located at top of STACK, this issue leads Platform Sec Lib
cannot get the correct CPU BIST information.
This fix is to address below issue:
https://tianocore.acgmultimedia.com/show_bug.cgi?id=123
Cc: Steven Shi <Steven.shi@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
Diffstat (limited to 'QuarkPlatformPkg')
| -rw-r--r-- | QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S b/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S index 2bb503f6a4..f35dbcfcd8 100644 --- a/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S +++ b/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S @@ -1,6 +1,6 @@ #------------------------------------------------------------------------------
#
-# Copyright (c) 2013 - 2015 Intel Corporation.
+# Copyright (c) 2013 - 2016 Intel Corporation.
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -263,7 +263,7 @@ L0: # Set up stack pointer
#
movl ASM_PFX(PcdGet32(PcdEsramStage1Base)), %esp
- movl $QUARK_STACK_SIZE_BYTES, %esi
+ movl $QUARK_ESRAM_MEM_SIZE_BYTES, %esi
addl %esi, %esp # ESP = top of stack (stack grows downwards).
#
|