summaryrefslogtreecommitdiffstats
path: root/SecurityPkg
diff options
context:
space:
mode:
authorRodrigo Gonzalez Del Cueto <rodrigo.gonzalez.del.cueto@intel.com>2022-09-22 15:35:36 +0800
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2022-09-30 12:00:24 +0000
commit7aa06237b856fd6f8187cc1715a3fe08ab4e98ed (patch)
treeb3473a668a26759115dc49ab9dbce97711d54d1f /SecurityPkg
parentb7213bbd59833fb0786c83a28df5f8244602ab5e (diff)
downloadedk2-7aa06237b856fd6f8187cc1715a3fe08ab4e98ed.tar.gz
edk2-7aa06237b856fd6f8187cc1715a3fe08ab4e98ed.tar.bz2
edk2-7aa06237b856fd6f8187cc1715a3fe08ab4e98ed.zip
SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4077 Following the design described in the TCG specification, the driver implementation of the CRB protocol does not require enforcing completing the transition to goIdle at the end of a command sequence. Signed-off-by: Rodrigo Gonzalez Del Cueto <rodrigo.gonzalez.del.cueto@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Jian J Wang <jian.j.wang@intel.com> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Diffstat (limited to 'SecurityPkg')
-rw-r--r--SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c13
1 files changed, 0 insertions, 13 deletions
diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
index 840265292a..1f9ac5ab5a 100644
--- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
+++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
@@ -381,19 +381,6 @@ GoIdle_Exit:
//
MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQUEST_GO_IDLE);
- //
- // Only enforce Idle state transition if execution fails when CRBIdleBypass==1
- // Leave regular Idle delay at the beginning of next command execution
- //
- if (GetCachedIdleByPass () == 1) {
- Status = PtpCrbWaitRegisterBits (
- &CrbReg->CrbControlStatus,
- PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE,
- 0,
- PTP_TIMEOUT_C
- );
- }
-
return Status;
}