ShellPkg/Shell: Use BaseLib api CharToUpper

Substitute InternalShellCharToUpper with a public function
CharToUpper which has the same function.
Remove the implement of InternalShellCharToUpper.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

1 files changed, 2 insertions, 23 deletions

diff --git a/ShellPkg/Application/Shell/ShellManParser.c b/ShellPkg/Application/Shell/ShellManParser.c
index b180c6c8f7..1d21f58cc8 100644
--- a/ShellPkg/Application/Shell/ShellManParser.c
+++ b/ShellPkg/Application/Shell/ShellManParser.c
@@ -1,7 +1,7 @@
 /** @file

   Provides interface to shell MAN file parser.

 

-  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR>

   Copyright 2015 Dell Inc.

   This program and the accompanying materials

   are licensed and made available under the terms and conditions of the BSD License

@@ -46,27 +46,6 @@ SHELL_MAN_HII_VENDOR_DEVICE_PATH  mShellManHiiDevicePath = {
   }

 };

 

-

-/**

-  Convert a Unicode character to upper case only if

-  it maps to a valid small-case ASCII character.

-

-  This internal function only deal with Unicode character

-  which maps to a valid small-case ASCII character, i.e.

-  L'a' to L'z'. For other Unicode character, the input character

-  is returned directly.

-

-  @param  Char  The character to convert.

-

-  @retval LowerCharacter   If the Char is with range L'a' to L'z'.

-  @retval Unchanged        Otherwise.

-

-**/

-CHAR16

-InternalShellCharToUpper (

-  IN CHAR16  Char

-  );

-

 /**

   Verifies that the filename has .EFI on the end.

 

@@ -416,7 +395,7 @@ IsTitleHeader(
           ReturnFound = TRUE;  // This is the desired command's title header line.

           State = (BriefDesc == NULL) ? Final : GetBriefDescription;

         }

-        else if (InternalShellCharToUpper (*Line) != InternalShellCharToUpper (*(Command + CommandIndex++))) {

+        else if (CharToUpper (*Line) != CharToUpper (*(Command + CommandIndex++))) {

           State = Final;

         }

         Line++;