ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues

1. Separate variable definition and initialization.
2. Make the variable naming following Edk2 rule.

V2: Remove the updates of guard macros in header files.

Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Evan Lloyd <evan.lloyd@arm.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

1 files changed, 15 insertions, 6 deletions

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c
index fbe943d898..043277aabf 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c
@@ -177,7 +177,10 @@ DumpSratApicProximity (
  IN UINT8*        Ptr

  )

 {

-  UINT32 ProximityDomain = Ptr[0] | (Ptr[1] << 8) | (Ptr[2] << 16);

+  UINT32 ProximityDomain;

+

+  ProximityDomain = Ptr[0] | (Ptr[1] << 8) | (Ptr[2] << 16);

+

   Print (Format, ProximityDomain);

 }

 

@@ -210,13 +213,19 @@ ParseAcpiSrat (
 {

   UINT32 Offset;

   UINT8* ResourcePtr;

-  UINT32 GicCAffinityIndex = 0;

-  UINT32 GicITSAffinityIndex = 0;

-  UINT32 MemoryAffinityIndex = 0;

-  UINT32 ApicSapicAffinityIndex = 0;

-  UINT32 X2ApicAffinityIndex = 0;

+  UINT32 GicCAffinityIndex;

+  UINT32 GicITSAffinityIndex;

+  UINT32 MemoryAffinityIndex;

+  UINT32 ApicSapicAffinityIndex;

+  UINT32 X2ApicAffinityIndex;

   CHAR8  Buffer[80];  // Used for AsciiName param of ParseAcpi

 

+  GicCAffinityIndex = 0;

+  GicITSAffinityIndex = 0;

+  MemoryAffinityIndex = 0;

+  ApicSapicAffinityIndex = 0;

+  X2ApicAffinityIndex = 0;

+

   if (!Trace) {

     return;

   }