summaryrefslogtreecommitdiffstats
path: root/ShellPkg/Library/UefiShellDebug1CommandsLib
diff options
context:
space:
mode:
authorMichael D Kinney <michael.d.kinney@intel.com>2023-03-11 11:31:51 -0800
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2023-03-13 22:11:55 +0000
commite4c1d8d2317984bd9cb447eba916956841063ec4 (patch)
treef62faf000feeda5676f6a8b1de08fb40b28ccd14 /ShellPkg/Library/UefiShellDebug1CommandsLib
parentd2bfe289668e32940cca5da12bc201bf9b6c84d8 (diff)
downloadedk2-e4c1d8d2317984bd9cb447eba916956841063ec4.tar.gz
edk2-e4c1d8d2317984bd9cb447eba916956841063ec4.tar.bz2
edk2-e4c1d8d2317984bd9cb447eba916956841063ec4.zip
ShellPkg/Library: Fix 32-bit truncation of pointer values
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4366 Update C and UNI files that are incorrectly using %x or %08x instead of %p for pointer values. On 64-bit systems, this is truncating pointer values above 4GB. In reviewing ShellPkg for this issue some unused UNI strings with incorrect format specifiers were removed instead of being fixed. Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com>
Diffstat (limited to 'ShellPkg/Library/UefiShellDebug1CommandsLib')
-rw-r--r--ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni2
1 files changed, 0 insertions, 2 deletions
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
index b1d239ed37..4fedc0d149 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
@@ -103,7 +103,6 @@
#string STR_DMEM_HEADER_ROW #language en-US "Memory Address %016LX %X Bytes\r\n"
#string STR_DMEM_MMIO_HEADER_ROW #language en-US "Memory Mapped IO Address %016LX %X Bytes\r\n"
-#string STR_DMEM_DATA_ROW #language en-US "%08X: %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x *%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c*\r\n"
#string STR_DMEM_SYSTEM_TABLE #language en-US "\r\nValid EFI Header at Address %016Lx\r\n"
"---------------------------------------------\r\n"
"System: Table Structure size %08x revision %08x\r\n"
@@ -1171,4 +1170,3 @@
" \r\n"
" * To edit memory region starting at address 0x00000000 with size of 2 bytes:\r\n"
" fs0:\> hexedit -m 0 2\r\n"
-