summaryrefslogtreecommitdiffstats
path: root/ShellPkg
diff options
context:
space:
mode:
authorJeff Westfahl <jeff.westfahl@ni.com>2017-03-15 05:02:01 +0800
committerRuiyu Ni <ruiyu.ni@intel.com>2017-03-17 12:25:14 +0800
commit7c6f0d14c3db1ade3e1ef701e39babd7a314eb56 (patch)
tree65f1a60377e57b0bc6eba988d8c3da00b6822998 /ShellPkg
parent56dee83a5503a30628cb101addff97d60243f5c2 (diff)
downloadedk2-7c6f0d14c3db1ade3e1ef701e39babd7a314eb56.tar.gz
edk2-7c6f0d14c3db1ade3e1ef701e39babd7a314eb56.tar.bz2
edk2-7c6f0d14c3db1ade3e1ef701e39babd7a314eb56.zip
ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage
The format specifier for the LoadOptions field of the LoadedImage protocol is "%s". However, the data in LoadOptions is often generic binary data. A format specifier of "%x" is more appropriate for this field. Using "dh -v" with format specifier "%s" on BIOS images based on EDK II source before commit 891d844 can cause a crash. Cc: Ruiyu Ni <ruiyu.ni@intel.com> Cc: Jaben Carsey <jaben.carsey@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Diffstat (limited to 'ShellPkg')
-rw-r--r--ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni2
1 files changed, 1 insertions, 1 deletions
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
index 0d51627c5f..273a4201bc 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
@@ -354,7 +354,7 @@
" DeviceHandle..: %%H%x%%N\r\n"
" FilePath......: %%H%x%%N\r\n"
" OptionsSize...: %%H%x%%N\r\n"
- " LoadOptions...: %%H%s%%N\r\n"
+ " LoadOptions...: %%H%x%%N\r\n"
" ImageBase.....: %%H%x%%N\r\n"
" ImageSize.....: %%H%Lx%%N\r\n"
" CodeType......: %%H%s%%N\r\n"