diff options
| author | Qiu Shumin <shumin.qiu@intel.com> | 2015-10-28 01:14:34 +0000 |
|---|---|---|
| committer | shenshushi <shenshushi@Edk2> | 2015-10-28 01:14:34 +0000 |
| commit | c617380446ec1228aa4c260b3eca775dbda5896b (patch) | |
| tree | 080c4c74a88b9dfc3a3442cb287e0098a30f877e /ShellPkg | |
| parent | ae658d9163afd6053db7d37d46f54388e33a0052 (diff) | |
| download | edk2-c617380446ec1228aa4c260b3eca775dbda5896b.tar.gz edk2-c617380446ec1228aa4c260b3eca775dbda5896b.tar.bz2 edk2-c617380446ec1228aa4c260b3eca775dbda5896b.zip | |
ShellPkg: Refine code by initializing local variable and adding ASSERT statement.
Add ASSERT statement and initialize local variable to make code more readable.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18689 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'ShellPkg')
| -rw-r--r-- | ShellPkg/Application/Shell/ShellProtocol.c | 2 | ||||
| -rw-r--r-- | ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c index af00fe401d..fc13595dbb 100644 --- a/ShellPkg/Application/Shell/ShellProtocol.c +++ b/ShellPkg/Application/Shell/ShellProtocol.c @@ -1632,6 +1632,8 @@ EfiShellExecute( EFI_DEVICE_PATH_PROTOCOL *DevPath;
UINTN Size;
EFI_STATUS CalleeStatusCode;
+
+ CalleeStatusCode = EFI_SUCCESS;
if ((PcdGet8(PcdShellSupportLevel) < 1)) {
return (EFI_UNSUPPORTED);
diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c index 02099febef..831b9c3d02 100644 --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c @@ -341,6 +341,7 @@ ShellCommandRunTftp ( }
RemoteFilePath = ShellCommandLineGetRawValue (CheckPackage, 2);
+ ASSERT(RemoteFilePath != NULL);
AsciiRemoteFilePath = AllocatePool (
(StrLen (RemoteFilePath) + 1) * sizeof (CHAR8)
);
|