diff options
| author | shenglei <shenglei.zhang@intel.com> | 2018-08-10 14:07:18 +0800 |
|---|---|---|
| committer | Star Zeng <star.zeng@intel.com> | 2018-08-20 14:27:14 +0800 |
| commit | 90b3f171a76cde0d824d17895d6ff7f434afe29c (patch) | |
| tree | 6c74f0abf906a6c56241560d5020a5c7076362f7 /SignedCapsulePkg/Universal | |
| parent | 43fe4c4052922c6baa36cf4664ce63b8699d9176 (diff) | |
| download | edk2-90b3f171a76cde0d824d17895d6ff7f434afe29c.tar.gz edk2-90b3f171a76cde0d824d17895d6ff7f434afe29c.tar.bz2 edk2-90b3f171a76cde0d824d17895d6ff7f434afe29c.zip | |
SignedCapsulePkg: Remove redundant things in inf,.h and .c files
Two redundant library classes have been removed.
The redundant function "IsSystemFmp" has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1067
v2: Remove DxeServicesLib from SystemFirmwareUpdateDxe.inf.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Diffstat (limited to 'SignedCapsulePkg/Universal')
4 files changed, 0 insertions, 31 deletions
diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c index 7f7a9a1982..8e16763597 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c @@ -343,31 +343,4 @@ InitializePrivateData ( return EFI_SUCCESS;
}
-/**
- Return if this FMP is a system FMP or a device FMP, based upon FmpImageInfo.
-
- @param[in] FmpImageInfo A pointer to EFI_FIRMWARE_IMAGE_DESCRIPTOR
-
- @retval TRUE It is a system FMP.
- @retval FALSE It is a device FMP.
-**/
-BOOLEAN
-IsSystemFmp (
- IN EFI_FIRMWARE_IMAGE_DESCRIPTOR *FmpImageInfo
- )
-{
- GUID *Guid;
- UINTN Count;
- UINTN Index;
-
- Guid = PcdGetPtr(PcdSystemFmpCapsuleImageTypeIdGuid);
- Count = PcdGetSize(PcdSystemFmpCapsuleImageTypeIdGuid) / sizeof(GUID);
- for (Index = 0; Index < Count; Index++, Guid++) {
- if (CompareGuid(&FmpImageInfo->ImageTypeId, Guid)) {
- return TRUE;
- }
- }
-
- return FALSE;
-}
diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h index 999b2b2501..cd6601e815 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h @@ -36,7 +36,6 @@ #include <Library/UefiDriverEntryPoint.h>
#include <Library/DevicePathLib.h>
#include <Library/HobLib.h>
-#include <Library/DxeServicesLib.h>
#include <Library/DxeServicesTableLib.h>
#include <Library/PlatformFlashAccessLib.h>
#include <Library/EdkiiSystemCapsuleLib.h>
diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf index cc9614ef14..b15736cf0d 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf @@ -50,9 +50,7 @@ HobLib
UefiRuntimeServicesTableLib
UefiDriverEntryPoint
- DxeServicesLib
DxeServicesTableLib
- PrintLib
EdkiiSystemCapsuleLib
[Pcd]
diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf index 2695fb6eb5..7ddea3679e 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf @@ -51,7 +51,6 @@ HobLib
UefiRuntimeServicesTableLib
UefiDriverEntryPoint
- DxeServicesLib
EdkiiSystemCapsuleLib
PlatformFlashAccessLib
IniParsingLib
|