summaryrefslogtreecommitdiffstats
path: root/UefiCpuPkg/CpuMpPei/CpuMpPei.h
diff options
context:
space:
mode:
authorJeff Fan <jeff.fan@intel.com>2015-12-18 03:22:56 +0000
committervanjeff <vanjeff@Edk2>2015-12-18 03:22:56 +0000
commitd603b1151c3b6d6961c65693063f16bb71a3c91c (patch)
tree44a1d64fd0c11c5a3f18a1347332362ccebe992e /UefiCpuPkg/CpuMpPei/CpuMpPei.h
parentbd6bb560a4aac215133c76c4915f4724c39b0844 (diff)
downloadedk2-d603b1151c3b6d6961c65693063f16bb71a3c91c.tar.gz
edk2-d603b1151c3b6d6961c65693063f16bb71a3c91c.tar.bz2
edk2-d603b1151c3b6d6961c65693063f16bb71a3c91c.zip
UefiCpuPkg/CpuMpPei: Fix pack(1) issue on x64 arch
Packing alignment for MP_CPU_EXCHANGE_INFO should be 1. This should be typo when check-in CpuMpPei driver. IA32 arch MP_CPU_EXCHANGE_INFO is luckly pack(1). It leads CpuMpPei x64 version hung. Contributed-under: TianoCore Contribution Agreement 1.0 Reported-by: Michael Kinney <michael.d.kinney@intel.com> Cc: Feng Tian <feng.tian@intel.com> Cc: Michael Kinney <michael.d.kinney@intel.com> Cc: Jordan Justen <jordan.l.justen@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan <jeff.fan@intel.com> Tested-by: Michael Kinney <michael.d.kinney@intel.com> Reviewed-by: Michael Kinney <michael.d.kinney@intel.com> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19340 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'UefiCpuPkg/CpuMpPei/CpuMpPei.h')
-rw-r--r--UefiCpuPkg/CpuMpPei/CpuMpPei.h4
1 files changed, 3 insertions, 1 deletions
diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.h b/UefiCpuPkg/CpuMpPei/CpuMpPei.h
index f2286b990e..2b960c6eb1 100644
--- a/UefiCpuPkg/CpuMpPei/CpuMpPei.h
+++ b/UefiCpuPkg/CpuMpPei/CpuMpPei.h
@@ -72,7 +72,7 @@ typedef struct {
typedef struct _PEI_CPU_MP_DATA PEI_CPU_MP_DATA;
-#pragma pack()
+#pragma pack(1)
typedef union {
struct {
@@ -95,6 +95,8 @@ typedef union {
//
// MP CPU exchange information for AP reset code
+// This structure is required to be packed because fixed field offsets
+// into this structure are used in assembly code in this module
//
typedef struct {
UINTN Lock;