diff options
| author | Eric Dong <eric.dong@intel.com> | 2017-10-19 10:40:16 +0800 |
|---|---|---|
| committer | Eric Dong <eric.dong@intel.com> | 2018-11-26 10:07:36 +0800 |
| commit | 9ae0b486247adeb4ab849fa4a39a9514b62912b3 (patch) | |
| tree | 9afe94e88e7a0af295fb95d23d93ee2f1e93baa0 /UefiCpuPkg/Library/MpInitLib/MpLib.c | |
| parent | 785e1699aca3a9b4cf5dfaa924b3a440b3080d3b (diff) | |
| download | edk2-9ae0b486247adeb4ab849fa4a39a9514b62912b3.tar.gz edk2-9ae0b486247adeb4ab849fa4a39a9514b62912b3.tar.bz2 edk2-9ae0b486247adeb4ab849fa4a39a9514b62912b3.zip | |
UefiCpuPkg/MpInitLib: Avoid call PcdGet* in Ap & Bsp.
MicrocodeDetect function will run by every threads, and it will
use PcdGet to get PcdCpuMicrocodePatchAddress and
PcdCpuMicrocodePatchRegionSize, if change both PCD default to dynamic,
system will in non-deterministic behavior.
By design, UEFI/PI services are single threaded and not re-entrant
so Multi processor code should not use UEFI/PI services. Here, Pcd
protocol/PPI is used to access dynamic PCDs so it would result in
non-deterministic behavior.
This code get PCD value in BSP and save them in CPU_MP_DATA for Ap.
https://bugzilla.tianocore.org/show_bug.cgi?id=726
Cc: Crystal Lee <CrystalLee@ami.com.tw>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
(cherry picked from commit 1e3f7a3782f1928a19bba81d9d0dba28d15fdae5)
Diffstat (limited to 'UefiCpuPkg/Library/MpInitLib/MpLib.c')
| -rw-r--r-- | UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c index a673d4f7b3..09a220a205 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -1393,6 +1393,8 @@ MpInitLibInitialize ( CpuMpData->SwitchBspFlag = FALSE;
CpuMpData->CpuData = (CPU_AP_DATA *) (CpuMpData + 1);
CpuMpData->CpuInfoInHob = (UINT64) (UINTN) (CpuMpData->CpuData + MaxLogicalProcessorNumber);
+ CpuMpData->MicrocodePatchAddress = PcdGet64 (PcdCpuMicrocodePatchAddress);
+ CpuMpData->MicrocodePatchRegionSize = PcdGet64 (PcdCpuMicrocodePatchRegionSize);
InitializeSpinLock(&CpuMpData->MpLock);
//
// Save BSP's Control registers to APs
|