diff options
| author | Eric Dong <eric.dong@intel.com> | 2018-11-09 13:20:41 +0800 |
|---|---|---|
| committer | Eric Dong <eric.dong@intel.com> | 2018-11-11 10:02:43 +0800 |
| commit | c1528b855c42b05886f90ad8c76c363b32ee7539 (patch) | |
| tree | 1911e3ae07defb72481bb3dd2de41f800300ff70 /UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | |
| parent | 8cd4e734ccdfbc961c72aeaa8dbd3f5154171f9b (diff) | |
| download | edk2-c1528b855c42b05886f90ad8c76c363b32ee7539.tar.gz edk2-c1528b855c42b05886f90ad8c76c363b32ee7539.tar.bz2 edk2-c1528b855c42b05886f90ad8c76c363b32ee7539.zip | |
UefiCpuPkg/RegisterCpuFeaturesLib: Adjust Order.
V2 changes:
V1 change has regression which caused by change feature order.
V2 changes logic to detect dependence not only for the
neighborhood features. It need to check all features in the list.
V1 Changes:
In current code logic, only adjust feature position if current
CPU feature position not follow the request order. Just like
Feature A need to be executed before feature B, but current
feature A registers after feature B. So code will adjust the
position for feature A, move it to just before feature B. If
the position already met the requirement, code will not adjust
the position.
This logic has issue when met all below cases:
1. feature A has core or package level dependence with feature B.
2. feature A is register before feature B.
3. Also exist other features exist between feature A and B.
Root cause is driver ignores the dependence for this case, so
threads may execute not follow the dependence order.
Fix this issue by change code logic to adjust feature position
for CPU features which has dependence relationship.
Related BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1311
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>
Diffstat (limited to 'UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h')
| -rw-r--r-- | UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h index b4c8ab777e..0a67a0581a 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h @@ -207,6 +207,22 @@ DetectFeatureScope ( );
/**
+ Return feature dependence result.
+
+ @param[in] CpuFeature Pointer to CPU feature.
+ @param[in] Before Check before dependence or after.
+ @param[in] FeatureList Pointer to CPU feature list.
+
+ @retval return the dependence result.
+**/
+CPU_FEATURE_DEPENDENCE_TYPE
+DetectNoneNeighborhoodFeatureScope (
+ IN CPU_FEATURES_ENTRY *CpuFeature,
+ IN BOOLEAN Before,
+ IN LIST_ENTRY *FeatureList
+ );
+
+/**
Programs registers for the calling processor.
@param[in,out] Buffer The pointer to private data buffer.
|