diff options
| author | Shenglei Zhang <shenglei.zhang@intel.com> | 2019-08-07 10:06:10 +0800 |
|---|---|---|
| committer | Liming Gao <liming.gao@intel.com> | 2019-08-13 17:20:32 +0800 |
| commit | 073f2cede820782e37e31bd6664aa53b79bbade4 (patch) | |
| tree | 1f90e768e2af2c8ba15005c9f6dee2c70f500169 /UefiCpuPkg/PiSmmCpuDxeSmm | |
| parent | c3eefcb152762cf8cca0b5a5d9938f03d4ea8e69 (diff) | |
| download | edk2-073f2cede820782e37e31bd6664aa53b79bbade4.tar.gz edk2-073f2cede820782e37e31bd6664aa53b79bbade4.tar.bz2 edk2-073f2cede820782e37e31bd6664aa53b79bbade4.zip | |
UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style
1. Update CPUStatus to CpuStatus in comments to align comments
with code.
2. Add "OUT" attribute for "ProcedureArguments" parameter in function
header.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Diffstat (limited to 'UefiCpuPkg/PiSmmCpuDxeSmm')
| -rw-r--r-- | UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 6 | ||||
| -rw-r--r-- | UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c index 328d7ae53a..d8d2b6f444 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c @@ -1967,7 +1967,7 @@ RegisterSmmEntry ( EFI_MP_SERVICES_PROTOCOL.StartupAllAPs.
If caller may pass a value of NULL to deregister any existing
startup procedure.
- @param[in] ProcedureArguments Allows the caller to pass a list of parameters to the code that is
+ @param[in,out] ProcedureArguments Allows the caller to pass a list of parameters to the code that is
run by the AP. It is an optional common mailbox between APs and
the caller to share information
@@ -1977,8 +1977,8 @@ RegisterSmmEntry ( **/
EFI_STATUS
RegisterStartupProcedure (
- IN EFI_AP_PROCEDURE Procedure,
- IN VOID *ProcedureArguments OPTIONAL
+ IN EFI_AP_PROCEDURE Procedure,
+ IN OUT VOID *ProcedureArguments OPTIONAL
)
{
if (Procedure == NULL && ProcedureArguments != NULL) {
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h index ed70055460..8c29f1a558 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h @@ -1311,7 +1311,7 @@ RestoreCr2 ( Note that timeout support is optional. Whether an implementation
supports this feature can be determined via the Attributes data
member.
- @param[in,out] CPUStatus This optional pointer may be used to get the status code returned
+ @param[in,out] CpuStatus This optional pointer may be used to get the status code returned
by Procedure when it completes execution on the target AP, or with
EFI_TIMEOUT if the Procedure fails to complete within the optional
timeout. The implementation will update this variable with
@@ -1437,8 +1437,8 @@ InternalSmmStartupAllAPs ( **/
EFI_STATUS
RegisterStartupProcedure (
- IN EFI_AP_PROCEDURE Procedure,
- IN VOID *ProcedureArguments OPTIONAL
+ IN EFI_AP_PROCEDURE Procedure,
+ IN OUT VOID *ProcedureArguments OPTIONAL
);
/**
|