diff options
| author | Star Zeng <star.zeng@intel.com> | 2018-01-12 12:59:03 +0800 |
|---|---|---|
| committer | Star Zeng <star.zeng@intel.com> | 2018-01-15 10:41:16 +0800 |
| commit | fe90d0d2ad3ed2e382fd1384fdf05969a95f2cdf (patch) | |
| tree | 3e1551b6fd053b7a89aace9fba7153c1d9dcaaad /UefiCpuPkg | |
| parent | 6e601a4109d4a998596986718653048ae23de0a6 (diff) | |
| download | edk2-fe90d0d2ad3ed2e382fd1384fdf05969a95f2cdf.tar.gz edk2-fe90d0d2ad3ed2e382fd1384fdf05969a95f2cdf.tar.bz2 edk2-fe90d0d2ad3ed2e382fd1384fdf05969a95f2cdf.zip | |
UefiCpuPkg PiSmmCpuDxeSmm: Remove redundant code to set IDT range to RO
AllocateCodePages() is used to allocate buffer for IDT range,
the code pages will be set to RO in SetMemMapAttributes(),
then the code to set IDT range to RO in PatchGdtIdtMap() is
redundant and could be removed.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Diffstat (limited to 'UefiCpuPkg')
| -rw-r--r-- | UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c index 16664f304c..2a4a298998 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c @@ -803,11 +803,10 @@ PatchGdtIdtMap ( BaseAddress = gcSmiIdtr.Base;
Size = ALIGN_VALUE(gcSmiIdtr.Limit + 1, SIZE_4KB);
- SmmSetMemoryAttributes (
- BaseAddress,
- Size,
- EFI_MEMORY_RO
- );
+ //
+ // The range should have been set to RO
+ // if it is allocated with EfiRuntimeServicesCode.
+ //
SmmSetMemoryAttributes (
BaseAddress,
Size,
|