diff options
author | Anastasia Klimchuk <aklm@chromium.org> | 2021-04-28 12:05:38 +1000 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2021-04-28 15:14:58 +0000 |
commit | 02350a6fcca8102d9927c6dbc6ce0095ac4051ba (patch) | |
tree | f11ae68e052ef24ed38e1cf3089e25062691dd64 | |
parent | 04fff28b462483f60ca1aff1362f106021e793db (diff) | |
download | flashrom-02350a6fcca8102d9927c6dbc6ce0095ac4051ba.tar.gz flashrom-02350a6fcca8102d9927c6dbc6ce0095ac4051ba.tar.bz2 flashrom-02350a6fcca8102d9927c6dbc6ce0095ac4051ba.zip |
mec1308.c: Ensure programmer param variable is always initialised
Programmer param variable is now declared inline with the code and
is const, so that it cannot be used uninitialised.
BUG=b:185191942
TEST=builds and ninja test from 51487
Change-Id: I2d2b3039da2ef185cb31509b3901d56b428688b7
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/52719
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r-- | mec1308.c | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -409,9 +409,7 @@ static struct spi_master spi_master_mec1308 = { static int check_params(void) { int ret = 0; - char *p = NULL; - - p = extract_programmer_param("type"); + char *const p = extract_programmer_param("type"); if (p && strcmp(p, "ec")) { msg_pdbg("mec1308 only supports \"ec\" type devices\n"); ret = 1; |