diff options
author | Miklós Márton <martonmiklosqdev@gmail.com> | 2022-03-16 23:21:04 +0100 |
---|---|---|
committer | Anastasia Klimchuk <aklm@chromium.org> | 2023-05-26 10:40:36 +0000 |
commit | ffc75aa710efc8796f0f34c30216ce8a2b1e3954 (patch) | |
tree | f34b5373d7f9641a2fc78e46e5ee57e75a43a426 | |
parent | 4fbb152402810c3ed07438de13dfc01efbb4d7d4 (diff) | |
download | flashrom-ffc75aa710efc8796f0f34c30216ce8a2b1e3954.tar.gz flashrom-ffc75aa710efc8796f0f34c30216ce8a2b1e3954.tar.bz2 flashrom-ffc75aa710efc8796f0f34c30216ce8a2b1e3954.zip |
git-hooks: echo back the commit message on failure
When using nano as a git commit message editor the contents of the
commit message could get lost if the git commit hook fails due to
the lack of Signed-off-by line. To prevent this unpleasant effect
for new contributors the commit hook was modified to echo back the
commit message to allow the user to copy-paste it to the message
of the next commit attempt.
Change-Id: I13289f81b3fa92640aecc43eae28c1643cd7c247
Signed-off-by: Miklós Márton <martonmiklosqdev@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/62879
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rwxr-xr-x | util/git-hooks/commit-msg | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/util/git-hooks/commit-msg b/util/git-hooks/commit-msg index d43eb4529..e2f5de512 100755 --- a/util/git-hooks/commit-msg +++ b/util/git-hooks/commit-msg @@ -196,6 +196,7 @@ _gen_ChangeId() { test_signoff() { if ! grep -qi '^[[:space:]]*\+Signed-off-by:' "$MSG"; then + cat "$MSG" printf "\nError: No Signed-off-by line in the commit message.\n" printf "See: ${DEV_GUIDELINES_URL}\n" exit 1 @@ -206,6 +207,7 @@ test_signoff() { test_duplicate_signoffs_acks() { test "" = "$(grep -i '^(Signed-off-by|Acked-by): ' "$MSG" | sort | uniq -c | sed -e '/^[[:space:]]*1[[:space:]]/d')" || { + cat "$MSG" echo "Duplicate Signed-off-by or Acked-by lines." >&2 exit 1 } |